One line patch to fix this.

CommentFileSizeAuthor
dba_pager.diff633 bytesZack Rosen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Jeremy’s picture

Status: Active » Fixed

Committed, thanks!

JordiTR’s picture

I've dived all the site to try to find a "4.7 compatible" version of that module and I see that you talk about it. Is there any place to download it?

Taran’s picture

Title: tablesort_pager removed in 4.7 » Concur. Where is the 4.7 release?!

This is an especially handy module, and I'm somewhat surprised that it hasn't made it into CORE yet. For upgrading older sites, this is a great convenience. Where is the 4.7 release?

doctrix’s picture

Category: bug » feature

I agree on how valuable this module is. This is one I install on all of my Drupal sites. I've been using the CVS version for Drupal 4.7 without apparent problems. Any update on the official 4.7 release?

Thanks for a very practical module.

Marc Bijl’s picture

Hmm.

I've installed cvs version as well (in combination with Drupal 4.7), but not all things work as they used to do. For example I miss the checkboxes in front of all the tables (so I cannot select them) and when trying to edit a row I get the message "Fatal error: Call to undefined function: form_textfield() in /home/example.com/public_html/modules/dba/dba.module on line 552".

So yes, I'm looking forward to 4.7 too (:

pancapangrawit’s picture

I'd like to second New Ocean - I have exactly the same problems.

The module is lovely, please update it :-)

best
.r.

Marc Bijl’s picture

Found this additional info in cvs changelog:

---------------
Forms API TODO: (patches welcome)
- properly implement all items on settings page to accept updates
- restore checkboxes next to table names on database overview
- restore 'edit row' functionality
There will be no 4.7 release until the above TODO list is empty.
---------------

Makes clear that maintainer is aware which things are not working yet.

Marc Bijl’s picture

Status: Fixed » Active

Comparing this topic's title with what I've found in the documentation (see previous post), I think the status should be active. May be it's an option to use this topic for updates regarding dba 4.7?

dww’s picture

Title: Concur. Where is the 4.7 release?! » porting DBA to 4.7
Category: feature » task
Status: Active » Postponed

to answer the question posed by the previous title "Where is the 4.7 release?!", as New Oceans points out, there is unfinished work needed to get this module fully functional with drupal 4.7 (in particular, the new Forms API, aka "FAPI"). the maintainer of DBA has said he doesn't want to branch (and therefore release) the 4.7 version until these problems are resolved. however, he's been out of town for a while, and while he agreed to give me cvs access to this module help work on this stuff, i've been totally overwhelmed with 1,000 other things.

to facilitate keeping track of these tasks, so folks can assign themselves individual parts to work on, etc, i've created 3 new issues:

http://drupal.org/node/68274 -- 4.7 port: properly implement all items on settings page to accept updates
http://drupal.org/node/68275 -- 4.7 port: restore checkboxes next to table names on database overview
http://drupal.org/node/68276 -- 4.7 port: restore 'edit row' functionality

if you have the means, please try to provide patches to resolve any/all of the above issues. i'll definitely notice any updates, and will try to review and test patches as quickly as possible. however, i'm not (yet) volunteering to write all the patches myself, so if anyone else can do so, please help! only once all 3 are fixed can we re-open this issue and make the 4.7 release.

thanks!
-derek

dww’s picture

just found some older issues in the queue for 2 of these tasks. the revised list is:

http://drupal.org/node/68274 -- 4.7 port: properly implement all items on settings page to accept updates
http://drupal.org/node/40661 -- 4.7 port: restore checkboxes next to table names on database overview
http://drupal.org/node/40660 -- 4.7 port: restore 'edit row' functionality

dww’s picture

Assigned: Unassigned » dww
Status: Postponed » Fixed

all the other patches are now done and committed.

i made the DRUPAL-4-7 branch.
i added a DRUPAL-4-7--1-0 tag for the initial 4.7.x-1.0 release (http://drupal.org/node/98518)

while i was at it, i also added an offical 4.6.x-1.0 release (http://drupal.org/node/98516) based on the DRUPAL-4-6--1-0 tag (off the DRUPAL-4-6 branch, of course), just so users have an official release to work from (in case we end up fixing any more bugs in 4.6).

dww’s picture

oh, and i made the 4.7.x-1.0 release the default download on the dba project node. ;)

Marc Bijl’s picture

Excellent stuff, good work mate!

By coincidence, after more than half a year or so, I decided to pick up one of my old sites again and just found out the dba module has been upgraded. Wow, what a timing...

Thanks!

venkat-rk’s picture

dww, thank you for your work.

Anonymous’s picture

Status: Fixed » Closed (fixed)