Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Following up on #480192: Add <itunes:keywords>, <itunes:author>, and <itunes:duration> elements. where we added the <itunes:author> element we should make it more flexible on where we get the author name from. I'd like a per-node-type option that's either: "- None -", Node Author, or any of that type's CCK text fields.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | itunes_481072.patch | 10 KB | drewish |
| #11 | itunes_481072.patch | 9.02 KB | drewish |
| #9 | itunes-vocab-defaultselect.patch | 536 bytes | JaredAM |
| #7 | itunes-481072-7.patch | 13.5 KB | guillaumeduveau |
| #6 | itunes-481072-6.patch | 12.05 KB | guillaumeduveau |
Comments
Comment #1
guillaumeduveauI got it working, will submit the patch tomorrow. I was just wondering, maybe CCK User Reference would be best for this (we can leave CCK textfield too).
Comment #2
guillaumeduveauHey Drewish, here's the patch against -dev. I'm sorry, I have no CVS access at work but I made a patch for multiple files with diff. Some file timestamps are wrong too because I started to work before your last commit. Hopefully I'll improve myself with CVS and patches !
Anyway, the patch allows to choose the source for itunes:author between :
- none
- node author
- a CCK Text Field of this nodetype, but textareas are not allowed : we obviously want something short for itunes:author
- a CCK User Reference field of this nodetype, and if multiple values are provided, they are imploded in a comma separated string
Let me know !
Guix
Comment #3
drewish commentedI haven't tested it but just looking at the patch that looks great. I'll be back in a few hours and take a look at it then.
Comment #4
guillaumeduveauHello Drewish, any updates on this ? If you prefer I can re-roll a patch against CVS with the good file timestamps.
Comment #5
drewish commentedokay i liked your choice of source naming and decided to rename the rest of the variables to match it. i also did a little clean up around it but it shouldn't be too different from your code. might taking a look at it? it probably needs some work.
Comment #6
guillaumeduveauI just found a typo in a variable name, otherwise I've reviewed and tested the code and everything is clean. I added some fixes for warnings found by Coder, too. I just hope you can work easily with the multiple files patches I did with diff (I've asked for CVS acces @work but it should take some time... IF I get it). See you !
Comment #7
guillaumeduveauI now have CVS access at work and I re-rolled a patch against CVS, is it more usable for you ?
Comment #8
JaredAM commentedI like where this module is going, but what if someone is using a node reference (as the author) to point to a staff page?
I suppose that someone could use nodeapi and get the node reference and insert it to the "node author" field on presave.
*Updated*
Never mind, I see where there is a userreference!
Comment #9
JaredAM commentedIn the new admin page, there is an issue with the Vocab and the default selected value. I've rolled a patch to catch this.
Comment #10
drewish commentedcommitted JaredAM's patch to HEAD.
also committed the documentation and white space changes from guix on #7. i'll re-roll a clean version of the patch in a minute.
Comment #11
drewish commentedhere's what's left of guix's changes. i dropped the @see -> See change since @see is better PHPDoc.
Comment #12
drewish commentedmade a few small changes and committed the following to HEAD.
Comment #13
guillaumeduveauThanks for the update and credits :)
Comment #14
drewish commentedof course! you're very welcome. thanks again for all your hard work. sorry i let it sit for so long before JaredAM prompted me to look at it.