Don't save formapi data for user registrations [#46255]

Comment	File	Size	Author
#6	unset_0.patch	449 bytes	chx

#3	unset.patch	427 bytes	chx

	user.module_23.diff	852 bytes	drumm

Comment #1

moshe weitzman CreditAttribution: moshe weitzman commented 25 January 2006 at 02:05

gosh, this bug again. we've seen it with system_settings and one other place. there are a few more system variables which might need to be unset() see http://drupal.org/node/41170. maybe we can do the unset() in a central place and then both of these issues will use that code?

Log in or register to post comments

Comment #2

Dries CreditAttribution: Dries commented 26 January 2006 at 09:03

+1 for fixing this in a central place.

Log in or register to post comments

Comment #3

chx CreditAttribution: chx commented 26 January 2006 at 12:39

Status:

Needs review

» Reviewed & tested by the community

File	Size
unset.patch	427 bytes

Log in or register to post comments

Comment #4

Dries CreditAttribution: Dries commented 26 January 2006 at 13:30

Can we clean up some code in system.module too?

Log in or register to post comments

Comment #5

NaX CreditAttribution: NaX commented 26 January 2006 at 14:05

I was looking in the PHP manuals at the unset function just before reading this issue and I would like to know if you want to unset these variables globally or locally.

If you in a function and you use unset() it only destroys the local version of the variable even if it is passed by reference.

To unset the global version of the variable you need to unset it using the $GLOBALS array. So my question is how do you want to unset these variables. Globally or locally, or is that unimportant.