Problem/Motivation

When upgrading to 2.2.3 and running drush updb I get the following error:

The deprecation template must contain the "%service_id%" placeholder.

This was caused by changes to metatag_page_manager.services.yml in #3616901: Deprecate Page Manager integration.

Proposed resolution

Update the deprecation template.

Remaining tasks

  • Review

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#6 fix-metatag-deprecation-template-issue.patch1.31 KBrahulk

Issue fork metatag-3633739

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jonasanne created an issue. See original summary.

jonasanne opened merge request !303

jonasanne’s picture

jonasanne commented

Created MR #303.
Can someone review and make a release for this please?

jonasanne’s picture

jonasanne commented
Assigned: jonasanne » Unassigned
Status: Active » Needs review
jonasanne’s picture

jonasanne commented
Issue summary: View changes
rahulk’s picture

rahulk commented
StatusFileSize
new fix-metatag-deprecation-template-issue.patch1.31 KB

Attached is a patch that replaces the hard-coded service names in the deprecation messages in metatag_page_manager.services.yml with the required %service_id% placeholder.

Symfony requires the deprecation template to contain %service_id%. Using %Drupal\metatag_page_manager\Hook\FormHooks% and %Drupal\metatag_page_manager\Hook\MetatagHooks% causes the "The deprecation template must contain the "%service_id%" placeholder." error during drush updb after upgrading to 2.2.3.

Steps to test:

  1. Install Metatag 2.2.3 with the metatag_page_manager submodule enabled.
  2. Run drush updb or drush cr and confirm the error appears.
  3. Apply the patch.
  4. Run drush cr and drush updb again and confirm the error is gone.
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Issue summary: View changes
Parent issue: » #3616901: Deprecate Page Manager integration
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs review » Reviewed & tested by the community

The patch works for me and appears to be the correct change.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: #3616901: Deprecate Page Manager integration » #3633976: Plan for Metatag 2.2.4
Related issues: +#3616901: Deprecate Page Manager integration

Sorry about that, it seems that I misread some core docs.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed

Committed. Thank you.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.