Fixed
Project:
Drupal core
Version:
12.0.x-dev
Component:
base system
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
16 Oct 2026 at 19:26 UTC
Updated:
30 Oct 2026 at 21:38 UTC
Jump to comment: Most recent
Problem/Motivation
#3566600: Deprecate drupal/core-dev-pinned metapackage and #3575461: Cleanup any remaining deprecations removed updates of the PinnedDevDependencies metapackage, but left the stale composer.json in as well as did not adjust EnsurePHPStanVersionsMatchTest.
This is causing packaging issues and test failures of the PHPStan rules.
Steps to reproduce
Composer update phpstan and see failures in PHPStan rule tests.
Proposed resolution
Remove the stale composer.json and adjust the test.
Remaining tasks
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
Issue fork drupal-3631365
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
mondrakeComment #4
mondrakeComment #5
godotislateThis looks right, but I'm not sure how this affects the subtree pushes. Presumably it should be correct to stop pushing them for 12.x? Somehow the https://github.com/drupal/core-dev-pinned repo has a 12.0.0-beta2 from three weeks ago, https://github.com/drupal/core-dev-pinned/releases/tag/12.0.0-beta2, even though the core release was yesterday.
Comment #6
mondrakeMore cleanup.
Comment #7
longwaveThe subtree splitter runs during the packaging process and as I understand it should just ignore this package as soon as we remove it from core. Only the DA have access to packaging logs so the only real way to find out is commit and see what happens.
One question on the MR.
Comment #8
xjm@drumm located the code that would need to be cbanged in packaging:
https://gitlab.com/drupal-infrastructure/subtree-splitter/-/blob/e0d13fe...
Comment #9
mondrakeCommented on the inline question.
Comment #10
mondrakeComment #11
mondrakeComment #12
longwaveOK, that makes sense, if we run into problems where PHPStan inadvertently breaks something we can always swap back to the old way.
This will need #8 to be modified by the DA or packaging of 12.0.x/main will start to fail.
Comment #13
drummhttps://gitlab.com/drupal-infrastructure/subtree-splitter/-/merge_reques... is the update for core packaging to remove that hard-coding.
Comment #14
xjmThe infra MR is merged, though not sure when exactly the deployment will happen. Sometime in the next few days was implied. :)
Comment #15
drummThe subtree splitter improvement, along with other fixes & a speed improvement are now committed, so this is unblocked.
Comment #16
xjmCan we maybe get a change record for the fact that it will now test with PHPStan on the latest version? I remain a bit worried that we're going to see frequent test failures from that; it belongs more in the updated deps job than the main job, I think. So I want people to be able to track that back here if it starts happening.
Meanwhile, I'm going to go ahead to commit this to unblock the now-lengthy chain of beta targets blocked on this.
Comment #18
xjmCommitted to main. It does not cherry-pick cleanly, so we need a backport version for 12.0.x. Thanks!
Comment #20
mondrakeNR for the backport
Comment #21
dcam commentedI wrote a change record.
I diffed the raw changes from the MRs. The only difference between the two is the required
drupal/coredependency in thecomposer.jsonfile. So the two MRs are equivalent. The backport looks good.Comment #23
xjmCommitted to 12.0.x and published the change record. Thanks!