PHPUnit 13 deprecates usage of with*() without expects() in mocks.
See pipeline raw logs in #3574681: [Nov 2026] Introduce support for PHPUnit 13.5 for full report.
Before adopting PHPUnit 13, fix the usages, either converting the mocks to stubs, or adding explicit expectations on the calls to the mocked method.
In this issue, do a third round with a limited (tbd) number of fixes.
| Comment | File | Size | Author |
|---|
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !17398
Comments
Comment #2
mondrakeOn it
Comment #4
mondrakeThese issues are incredibly tedious. Let’s do small steps.
Comment #5
dcam commentedDoes that mean you want me to hold off on reviewing?
Comment #6
dcam commentedNevermind. I got the impression that you intended to add more changes.
Comment #7
mondrake#5 no no the contrary - I suggest doing just a few files in every issue - simpler to do (I do fixes with PHPUnit 13, then run the suite with the MR of the bump to make sure I do not get other overall errors, then apply selectively a diff to the MR of the individual issue, re run the suite on PHPUnit 12 to ensure I do not get errors on current HEAD), and to review (the changes never look obvious).
So please, DO review if you can ;)
Comment #8
dcam commentedAs usual, I looked at these changes and attempted to verify that after the modifications the tests are still testing the things we expect. I found one that I think didn't go far enough. In
ConfigEntityMapperTestI think it's more appropriate to remove the$routeProviderproperty entirely.Comment #9
mondrakeThanks. Done.
Comment #10
dcam commentedLooks good.
Comment #11
mstrelan commentedI left a question on the MR, can set back to RTBC once it's answered.
Comment #12
mondrakeAddressed @mstrelan's input, for review
Comment #13
dcam commentedI'm setting the status to Needs Work because I believe that last change needs to be undone.
Comment #14
mondrakeReverted, going back to previous RTBC
Comment #15
mstrelan commentedThis will need rebasing again now that we're on phpstan level 3.
Comment #16
mondrakeFixed newly reported PHPStan L3 errors.
Comment #17
dcam commentedUserAuthenticationTest::testAuthenticateWithZeroPassword()is an anachronism that needs to be deleted. There is an RTBC issue to remove it at #3570206: Delete UserAuthenticationTest::testAuthenticateWithZeroPassword(). I'll open a thread in Slack to see if we can move that one forward.Comment #18
dcam commentedMy thread in Slack got no responses. So I'm going to RTBC this and I'll deal with rebasing the other issue after this one gets committed. I looked over the changes and they're good.
Comment #19
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #20
dcam commentedLooks like it needed a rebase.
Comment #23
mstrelan commentedCommitted and pushed 9b26fc7ce1d to main and c70c55f5a01 to 12.0.x. Thanks!