PHPUnit 13 deprecates usage of with*() without expects() in mocks.
See pipeline raw logs in #3574681: [Nov 2026] Introduce support for PHPUnit 13.5 for full report.
Before adopting PHPUnit 13, fix the usages, either converting the mocks to stubs, or adding explicit expectations on the calls to the mocked method.
In this issue, do a third round with a limited (tbd) number of fixes.
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
mondrakeOn it
Comment #4
mondrakeThese issues are incredibly tedious. Let’s do small steps.
Comment #5
dcam commentedDoes that mean you want me to hold off on reviewing?
Comment #6
dcam commentedNevermind. I got the impression that you intended to add more changes.
Comment #7
mondrake#5 no no the contrary - I suggest doing just a few files in every issue - simpler to do (I do fixes with PHPUnit 13, then run the suite with the MR of the bump to make sure I do not get other overall errors, then apply selectively a diff to the MR of the individual issue, re run the suite on PHPUnit 12 to ensure I do not get errors on current HEAD), and to review (the changes never look obvious).
So please, DO review if you can ;)
Comment #8
dcam commentedAs usual, I looked at these changes and attempted to verify that after the modifications the tests are still testing the things we expect. I found one that I think didn't go far enough. In
ConfigEntityMapperTestI think it's more appropriate to remove the$routeProviderproperty entirely.Comment #9
mondrakeThanks. Done.
Comment #10
dcam commentedLooks good.
Comment #11
mstrelan commentedI left a question on the MR, can set back to RTBC once it's answered.