Problem/Motivation

The Caption description summary in both GLightbox image formatters shows the Caption setting instead of the Caption description setting.

Steps to reproduce

  1. Configure the GLightbox or GLightbox Responsive image formatter under Manage display.
  2. Set Caption to None and Caption description to Custom (with tokens).
  3. Click Update. The summary incorrectly shows “GLightbox caption description: None” instead of “Custom (with tokens)”.

Proposed resolution

Use the Caption description setting when building its summary in both formatters.

Equivalent video-module issue: #3628653.

Remaining tasks

Review and merge the MR.

User interface changes

The summary correctly reports the selected Caption description option.

Issue fork glightbox-3628658

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nick hope created an issue. See original summary.

nick hope opened merge request !17

nick hope’s picture

nick hope commented
Assigned: nick hope » Unassigned
Issue summary: View changes
Status: Active » Needs review
nick hope’s picture

nick hope commented
Related issues: +#3628653: Caption description summary shows the Caption setting

levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
commented
Status: Fixed » Closed (fixed)