Problem/Motivation

The remote-video formatter's Caption description summary shows the Caption setting instead of the Caption description setting.

Steps to reproduce

  1. Configure the GLightbox remote-video formatter under Manage display.
  2. Set Caption to None and Caption description to Custom (with tokens).
  3. Click Update. The summary incorrectly shows “GLightbox caption description: None” instead of “Custom (with tokens)”.

Proposed resolution

Use the Caption description setting when building its summary.

Equivalent image-module issue: #3628658.

Remaining tasks

Review and merge the MR.

User interface changes

The summary correctly reports the selected Caption description option.

Issue fork glightbox_media_video-3628653

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nick hope created an issue. See original summary.

nick hope opened merge request !11

nick hope’s picture

nick hope commented
Assigned: nick hope » Unassigned
Issue summary: View changes
Status: Active » Needs review
nick hope’s picture

nick hope commented
Issue summary: View changes
Related issues: +#3628658: Caption description summary shows the Caption setting

levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
commented
Status: Fixed » Closed (fixed)