Internal fields and disabled fields are instantiated before being filtered out, which is wasteful.
We know whether a field is internal or enabled based on its definition and the resource type. Sites that disable fields with ResourceTypeBuildEvent::disableField() or JSON:API Extras pay for every disabled field on every entity.
node--article in a ResourceTypeBuildEvent subscriber using $event->disableField()./jsonapi/node/article with a profiler enabled.ContentEntityBase::get() is called for every field of every article, including the disabled ones.Filter before getting the fields by checking the field definitions and then calling get() only for enabled, non-internal fields.
This is not a thorough test, but I ran the numbers for my own site with AI assistance on FrankenPHP in worker mode and found the following. For 50 entities, ContentEntityBase::get() calls fell from 1,772 to 577. Observed request duration decreased from about 600 ms to about 400 ms with XHProf enabled (XHProf overhead seems to be about 10x). My site may have an especially large speedup because I have many disabled fields.
AI disclosure: I used AI to help prepare the IS and MR (Claude Code with Opus 5.5).
| Comment | File | Size | Author |
|---|
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
ptmkenny commentedComment #4
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #5
ptmkenny commentedFixed the phpstan error described in #4.