Problem/Motivation

I have been experimenting running Drupal with FrankenPHP in worker mode, which is a persistent app server (the container is not reset between requests).

Executing multiple drush commands in behat gave me an OOM error, which I traced to metatag_views module.

metatag_views calls $view->preExecute() but not $view->postExecute(). preExecute() pushes
the previous $GLOBALS['_current_view'] onto $view->old_view and sets the global to this view; only postExecute() pops it back.

As a result, after a metatag page-attachment render on a Views page, the global keeps the view. The next such render chains it into old_view, which builds a list that grows forever and pins every service container the views were built with.

Measured: about 25 MB of additional RAM used per container rebuild, reaching 1 GB in a 500-request worker lifetime.

Proposed resolution

Call postExecute() to clean up.

CommentFileSizeAuthor
#8 3626128.png97.3 KBcsakiistvan

Issue fork metatag-3626128

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ptmkenny created an issue. See original summary.

ptmkenny opened merge request !273

ptmkenny’s picture

ptmkenny commented
Title: metatag_views calls $view->preExecute() but not $view->postExecute() » metatag_views calls $view->preExecute() but not $view->postExecute(), leading to OOM error
ptmkenny’s picture

ptmkenny commented
Related issues: +#2218651: [meta] Make Drupal compatible with persistent app servers like ReactPHP, PHP-PM, PHPFastCGI, FrankenPHP, Swoole
ptmkenny’s picture

ptmkenny commented
Status: Active » Needs review

Tests are not passing, but that appears to be due to the new D12 attributes requirements and migrate module deprecation, so I'm tentatively setting to "Needs review."

ptmkenny’s picture

ptmkenny commented

Ah, tests are broken by #3625969: Twig's 3.30 TypeError: Twig\Runtime\EscaperRuntime::escape(): Argument #4 ($autoescape) must be of type bool, null given, nothing to do with this.

csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Assigned: Unassigned » csakiistvan
csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Assigned: csakiistvan » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3626128.png97.3 KB

✅ Tested and works — applied MR !273, rebuilt caches and called metatag_views_get_view_tags() five times in one drush process: the old_view chain behind $GLOBALS['_current_view'] grew by one per call before the fix and stays at 0 after it. The leak is fixed, and FrankenPHP is not needed to reproduce it.

damienmckenna made their first commit to this issue’s fork.

damienmckenna changed the visibility of the branch 2.2.x to hidden.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #3634032: Plan for Metatag 2.2.5

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed

Committed.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.