Widget does not preselect stored values on edit forms since 2.0.4 (regression from #3517342)

Patch applies and looks to work.

I am having the same issue as described. The patch resolves the issue.

Thanks for the patch - it does seem to address the issue, from my initial tests.

Not aware of the history on #3517342: Widget loads references that it never uses, causing increased memory usage

Patches are now deprecated on drupal.org, see Creating merge requests instead.

I've taken the patch and put it into https://git.drupalcode.org/project/shs/-/merge_requests/58

@malcomio Thanks for filing MR!58

Confirming the patch worked on four Drupal 10.6.16 / PHP 8.3 sites.

I believe this issue is 2.0.7 only, not 2.0.4 - 2.0.7.

The empty `getOptions()` from #3517342 has been there since 2.0.4, but shs also carried its own `getSelectedOptions()` override returning the stored `target_id`s unfiltered. The override is present in 2.0.3, 2.0.4, 2.0.5 and 2.0.6, and absent only in 2.0.7.

This caused a silent data loss in addition to a display problem. The widget renders "- None -", and the next save writes an empty value and deletes the stored term. On our site every product save erased its category tag causing products to lose their taxonomy references.

The patch also worked for me Drupal 11.4.7

Thank you @philltran for confirming this issue only arose in version 2.0.7, that is very helpful for when I need to advise my client.

The patch worked also for me on core 11.4.7 and shs on 2.0.7

I am bumping this as it causes data-loss from the DB using 2.0.7

If you got revisions enabled you can get the data back from a revision.

The patch works

MR !59 is based on !58 and keeps its fix, while also preserving the behaviour from #3359851.

!58 brings #3359851 back

!58 returns the stored values unfiltered. When a referenced term has been deleted, the stale ID is preselected, and the entity reference constraint then rejects the save:

The referenced entity (taxonomy_term: X) does not exist.

The entity can no longer be saved at all, and there’s no way to clear the value through the UI — arguably worse than the empty widget. That’s exactly what #3359851 removed this override to fix.

It shows in !58’s own pipeline, which is red:

Drupal\Tests\shs\Functional\ShsTermTest 4 passed, 1 failed Fail testEditNodeWithDeletedTerm Behat\Mink\Exception\ResponseTextException: The text "... has been updated." was not found anywhere in the text of the current page.

The phpunit job is allow_failure: false, so this blocks. The manual confirmations above wouldn’t catch it, because the symptom only appears on content referencing a deleted term. On our site, 10 of 50 affected nodes are in that state.

!59 fixes it

!59 drops values whose target no longer exists, resolved with a single entity query — so no referenced entities are loaded, and the memory saving from #3517342 is preserved.

Its pipeline is green:

Drupal\Tests\shs\Kernel\OptionsShsWidgetDefaultValueTest 4 passed Drupal\Tests\shs\Functional\ShsTermTest 5 passed Pass testEditNodeWithDeletedTerm

phpunit, phpcs, and cspell pass. eslint and phpstan fail, but they fail on 2.0.x as well and are non-blocking, so they’re pre-existing.

No new test was needed — the existing testEditNodeWithDeletedTerm already covers the regression.

Verified on Drupal 11.4.8 / shs 2.0.7: valid terms preselect, stale references are dropped, mixed live/dead preserves order, and a node holding a stale reference saves and clears.

Credit to @carlitus for the diagnosis and test, and @malcomio for !58.

The patch in merge request 59 fixes it for us.

Patch 59 didn't help me; there is no option to select the value. Only version 2.0.5 works. Please fix this in the official release!