Problem/Motivation

In the core/modules/migrate/tests/src/Kernel/MigrateSourceTestBase.php there seems to be a typo about the annotation name, it states #[CoverClass] instead of #[CoversClass]

Steps to reproduce

See docs

Proposed resolution

Update the docs.

Remaining tasks

MR

User interface changes

N/A

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Issue fork drupal-3610474

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bramdriesen created an issue. See original summary.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Active » Needs review

bramdriesen opened merge request !16302

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented

MR seems to be not showing? https://git.drupalcode.org/project/drupal/-/merge_requests/16302

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Related issues: +#3547173: Complete test annotations to attributes conversion for all remaining tests

Introduced in https://www.drupal.org/project/drupal/issues/3547173

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Title: Typo in doc about #[CoversClass] » MigrateSourceTestBase has a typo about #[CoversClass]
bbrala’s picture

bbrala
Location Netherlands
commented
Status: Needs review » Reviewed & tested by the community

Yeah that covers it. ;)

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented

+1 for RTBC

I searched core/ for "coverclass" (case insensitive) and did not find any other matches.

This typo seems to have been introduced in #3547173: Complete test annotations to attributes conversion for all remaining tests.

  • larowlan committed 12e1396d on 11.4.x 
    fix: #3610474 MigrateSourceTestBase has a typo about #[CoversClass]

By...

  • larowlan committed 23143727 on 11.x 
    fix: #3610474 MigrateSourceTestBase has a typo about #[CoversClass]

By...

  • larowlan committed 30586256 on main 
    fix: #3610474 MigrateSourceTestBase has a typo about #[CoversClass]

By...

larowlan closed merge request !16302

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Version: main » 11.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 30586256bfd to main and 2314372710d to 11.x and 12e1396dcf2 to 11.4.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.