Replace annotation-based test metadata with PHP attributes.
1) Complete manually the conversion done automatically for Kernel in #3545163: Convert test annotations to attributes in core’s Kernel tests using Rector rule and #3543586: Convert test annotations to attributes in modules' Kernel tests using Rector rule with the remaining outliers.
2) Fix any straggler in any test suite.
3) Set PHPUNIT_FAIL_ON_PHPUNIT_DEPRECATION: true for all test jobs in CI so to 'seal' the testsuites from regressions in using annotation metadata.
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !13281
Comments
Comment #2
mondrakeComment #4
mondrakeLast blocker is in, this is workable now. On it.
Comment #5
mondrakeComment #6
smustgrave commentedSince that bulk kernel impacted a number of tickets think it would be good to get this in early while people are still rebasing those MRs.
Comment #7
mondrakeComment #8
quietone commentedI reviewed the MR and the test file changes looks correct to me. I did note that the three test files for views plugins in sqlite, mysql, and pgsql have the addition of
#[Group('views')]when there is not a corresponding '@group views' annotation. I haven't kept up with the gitlab files, so am not commenting on those.Comment #9
mondrake#8 that's a side effect of cleaning up the same annotation from the abstract base class
views/tests/src/Kernel/Plugin/CastedIntFieldJoinTestBase: since class-level annotations are noop on abstract classes, I removed that from there, but then added it back to the concrete classes.Comment #11
longwaveThanks for keeping up with this - let's land this now to avoid yet another rebase.
Committed 46c6a19 and pushed to 11.x. Thanks!