Closed (fixed)
Project:
Drupal core
Version:
main
Component:
extension system
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
9 Jun 2026 at 00:59 UTC
Updated:
31 Oct 2026 at 02:50 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mradcliffeAdded link to #2894476: [PP-1] Provide commands which are helpful for core development that was the original feature request, but no work was done on uninstalling extensions in that issue.
Comment #3
nicxvan commentedComment #4
mradcliffeUpdated parent to the "stable" meta. Added testing instructions.
Comment #5
ressaI would like to suggest that old aliases are not included, so that only
ex:uninstalland its aliasexunare available.General help
Comment #6
moshe weitzman commentedAssigning to me.
Comment #8
moshe weitzman commentedReady for review. Closely matches the code flow and UX of the new ex;install command.
Comment #9
mradcliffeComment #12
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #13
nicxvan commentedOk I manually ran through the following test scenarios similar to the install command tests:
With CLI
IN UI
I called two modules, one already uninstalled- N/AI uninstalled a theme with subtheme dependencies- N/AI uninstalled an already uninstalled module- N/AI uninstalled a module and theme at the same time- N/AI uninstalled the default theme- N/AHappy to report that everything worked!
@godotislate mentioned in slack that main is now for criticals and 12.x only for a bit so I think this won't get in until 12.x beta is out which means we'll need a separate CR for this.
The test still needs to be moved to the Extension test namespace.
I had wondered if some of the command code can be refactored into helpers since it looks like a few chunks are almost identical. I think that might be premature since this is only the second use, and there are enough minor differences that it could be painful.
Comment #14
moshe weitzman commentedThe Needs Review bot is again defacing issues by moving the status to Needs Work and attaching a file "Patch fails to apply". We dont use patches anymore. Also, the MR is mergeable as seen on this issue and on the MR itself.
If someone could review this that would be appreciated.
Comment #15
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #16
nicxvan commentedThere is something weird going on for sure.
I pulled the diff down https://git.drupalcode.org/project/drupal/-/merge_requests/17083.diff and created a patch from it.
When I apply that to main I get an error:
If you look at the diff it still references those files even though the MR doesn't appear to, I think gitlab or fastly is caching something incorrectly.
For the record the bot says patches, but it's using the MR as well.
Comment #17
moshe weitzman commentedGit has smarts to know about file moves/renames and all sorts of things. Thats why MRs stay green longer than patches too. Now that we have change proposals in git, I dont see value in knowing whether a derived patch would apply cleanly. I wrote about this 10 years ago.
Comment #18
nod_The process of a core commit involves applying the .diff to the codebase, that's why the bot test for that. Bot is here to make sure a RTBC issue is committable at all times, without relaunching a unreasonable amount of CI test runs, which is why it doesn't trigger a rebase automatically either.
Comment #19
nicxvan commentedOk I rebased, we still need the CR I think.
Comment #20
mradcliffeThe Drupal Contribution Mentoring team is triaging issues for DrupalCon Rotterdam 2026, and we are reserving this issue for Mentored Contribution during the event.
After October 3, this issue returns to being open to all. Thanks!
I performed Novice Triage on this issue. I am adding the Novice tag for creating a change record for the new methods that are added on the merge request. This is a non-code contribution opportunity.
Please remove the Needs change record and/or Needs issue summary update tags once that task is complete.
Comment #21
kristiantosney commentedI am at DrupalCon Rotterdam 2026, today I will be working on this issues. My mentor is Ekes.
Comment #22
kristiantosney commentedI have written a change record for review on this issue.
Comment #23
mradcliffe@kristiantosney Thank you for creating the change record. I forgot to mention this in my comment, but this should document the new methods on the respect Uninstall interfaces. If you have time, would you be able to update the change record so that it is similar to https://www.drupal.org/node/3623057?
Comment #24
vasyl vasylkiv commented@mradcliffe, I added the description for CR according to https://www.drupal.org/node/3623057/ example
Comment #25
mradcliffe@vasyl vasylkiv, thank you for updating the change record. However the change record needs to document the two new methods on the interface similar to the other change record you linked. I would probably title similarly as well.
Comment #26
moshe weitzman commentedThis issue is now held up on a change record on an interface which virtually noone has ever extended. And will that person actually find and benefit from this CR? If someone finds an issue with an MR, it would be ideal if they made the accompanying change in order to keep it moving forward. Thank you.
Comment #27
larowlanRepurposed the change record - onwards
Comment #28
nicxvan commentedYes, we still need a change record though.
I updated the change record a bit, I think it's good to go.
People can do that, but then it generally removes their ability to RTBC cleanly, it's usually better for one person to take point.
In any case I think this is ready!
Comment #29
moshe weitzman commented> People can do that, but then it generally removes their ability to RTBC cleanly, it's usually better for one person to take point.
Thanks for moving this along.
IMO its a bug in the policy if we are preventing or disincentivizing a person from making a fix when they see a problem in an MR. We should prioritize forward progress, not high fidelity to a peer review flow. It is still within the spirit of our workflow to make improvements AND provide the RTBC. Remember, rules are meant to be broken (wisely).
Comment #30
larowlanManually tested
Works like it says on the tin
I wonder if we have plans to support variadic arguments rather than a csv list?
Comment #31
larowlanTested a few other scenarios
Comment #33
larowlanCommitted and pushed 3b94128e929 to main. Thanks!
Published the change record
Comment #35
nicxvan commented