Problem/Motivation

The https://www.drupal.org/project/js_cookie module's latest branch is 2.x but this module's composer file only allows for compatibility with the older 1.x branch.

Proposed resolution

Update the composer.json to be compatible with the 2.x branch of js_cookie.

Issue fork fpa-3593356

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jastraat created an issue. See original summary.

jastraat opened merge request !13

jastraat’s picture

jastraat commented
Status: Active » Needs review

To test, modify composer.json in the following way:

Update the repositories section so that you are pulling the fpa module from the fork:

    "repositories": [
        {
            "type": "composer",
            "url": "https://packages.drupal.org/8",
            "exclude": [
                "drupal/fpa"
            ]
        },
        {
            "type": "git",
            "url": "https://git.drupalcode.org/issue/fpa-3593356.git"
        },

Update composer.json to point fpa to the branch of this issue:

"drupal/fpa": "dev-3593356-update-composer.json-to",

Run composer update:

composer update drupal/fpa --with-dependencies

Confirm js_cookie module is updated to the latest 2.x version.

As an administrator, navigate to /admin/people/permissions and make sure filtering permissions works as previously.

  • jastraat committed 8fe541ee on 4.0.x 
    Issue #3593356: Allow 2.x branch of js_cookie
astonvictor’s picture

astonvictor commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

astonvictor’s picture

astonvictor commented

merged to the dev version

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.