We added a new coding standards rule, Classes and interfaces without a backslash \ inside their fully-qualified name must be fully qualified, this should be changed.
Add the SlevomatCodingStandard.Namespaces.FullyQualifiedExceptions rule and run phpcs
This does not seem to do what we need to do.
SlevomatCodingStandard.Namespaces.FullyQualifiedExceptions added to phpcs, run phpcbf to fix all instances where it needs to be updated.
This does not seem to do what we need to do.
| Comment | File | Size | Author |
|---|
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
quietone commentedComment #5
bramdriesenComment #6
bramdriesenWe have a conflicting rule
Drupal.Classes.FullyQualifiedNamespace.UseStatementMissing. I removed that, but I'm not sure if that's the correct way to do it.This will need a rebase, a lot so I'm not going to do that now as it will be a challenge to keep up with Core.
Comment #7
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. The merge request has merge conflicts and cannot be merged. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #8
borisson_It seems like this rule doesn't fully do what we wanted it to do, since this is supposed to be only for classes that don't have a \ in their FQN. Should we find (or write) another rule?
Comment #9
quietone commentedThis is unfortunate. I just spent some time searching for another solution and didn't find one. So, I reckon an issue in Coder is needed.