Problem/Motivation

Fix code style (phpcs. phpstan, styleint, cspell, eslint, ...)

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork ckeditor_mentions-3582599

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

yusuf_khan made their first commit to this issue’s fork.

yusuf_khan’s picture

yusuf_khan commented
Assigned: Unassigned » yusuf_khan

im working on this issue

anybody opened merge request !51

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@yusuf_khan thanks, will you do it immediately? We'd like to get the issues finished in the next hours. If not, please unassing, thanks!

lrwebks’s picture

lrwebks commented
Assigned: yusuf_khan » lrwebks
lrwebks’s picture

lrwebks commented

We have a bit of a problem here. The plugin MentionsUpgrade is a plugin for the class CKEditor4To5UpgradePluginInterface of the ckeditor5 module which doesn't exist anymore. That is why multiple tools including PHPCS and PHP Stan complain about it. What can we do about this? Is removing that file technically a breaking change in this case? I mean, with the current version of ckeditor5 it wouldn't work either way.

grevil’s picture

grevil commented
Title: Fix code style (phpcs. phpstan, styleint, cspell, eslint, ...) » [4.x] Fix code style (phpcs. phpstan, styleint, cspell, eslint, ...)
Issue tags: -Novice

Let's clean this up in 4.x

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Title: [4.x] Fix code style (phpcs. phpstan, styleint, cspell, eslint, ...) » Fix code style (phpcs. phpstan, styleint, cspell, eslint, ...)
Version: 3.0.x-dev » 4.x-dev

Let's solve this in 4.x

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Won't be solvable in 3.x which is ^10.3 and ^11 compatible but ^11 misses the classes. See https://www.drupal.org/project/drupal/issues/3239012

grevil’s picture

grevil commented
Title: Fix code style (phpcs. phpstan, styleint, cspell, eslint, ...) » [4.x] Fix code style (phpcs. phpstan, styleint, cspell, eslint, ...)
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Related issues: +#3582825: [4.x] Remove the CkEditor4to5 Upgrade Plugin
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: lrwebks » grevil
Status: Active » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: grevil » Unassigned
Status: Needs review » Needs work

Okay still a lot of things to resolve here!

lrwebks’s picture

lrwebks commented
Assigned: Unassigned » lrwebks
lrwebks’s picture

lrwebks commented
Assigned: lrwebks » Unassigned

I've adjusted what I could, a few threads are ready to resolve, but I cannot do that as I am not a module maintainer. A few issues are left open like the deprecation issue and the ESLint problem, but I probably can't be of much help there.

lrwebks’s picture

lrwebks commented
Status: Needs work » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

@lrwebks: Please fix these.

See https://www.drupal.org/node/3568136 for the replacement regarding your comment. You might have found that.

lrwebks’s picture

lrwebks commented

Can't fix the deprecation issue by using the new function from https://www.drupal.org/node/3568136, as it does not yet exist in the current version. If we use this for the next minor version right now, we break the current version which is even worse.

lrwebks’s picture

lrwebks commented
Status: Needs work » Needs review

Okay, so I will turn the deprecation issue into a follow-up.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@lrwebks: phpunit still needs to be fixed

I tried .eslintignore, let's see.

Otherwise, we could give https://eslint.org/docs/latest/use/configure/ignore
a try for /js/build

There's even a perfect example?
https://eslint.org/docs/latest/use/configure/ignore#name-the-global-igno...

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Funny! The broken test was a regression caused by typo correction xD
Maybe not the best idea ...

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

  • anybody committed 8f96b35d on 4.x 
    feat: #3582599 [4.x] Fix code style (phpcs. phpstan, styleint, cspell,...
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.