Problem/Motivation

Since in most of our sites we have used Generic DAM asset media type with media_acquiadam module to fetch different types asset from DAM, so as part of this migration, we have executed this step to drush acquia-dam:resolve-asset-media-type to migrate .svg, .png, .jpg assets from Generic DAM Asset media type to Acquia dam image media type specific.

But we are seeing an issue with .svg asset types not able migrate from generic DAM. Asset media type to Acquia DAM image media type specific and it is showing below error.

After further exploring acquia_dam module code, we found that , SVG asset types are not supported with acquia_dam. Please refer to this one in https://git.drupalcode.org/project/acquia_dam/-/blob/1.1.x/src/Entity/Ma...

It's crucial for our applications to be able to successfully fetch .svg assets from DAM with acquia_dam module, we also have lot .svg assets being rendered across all of our Prod sites.

We can't even able to fetch any new .svg assets from DAM to our Individual sites with acquia_dam module with media library. Assets belongs to Generic media type.

CommentFileSizeAuthor
#6 3576979-acquia-dam-svg-support-with-download-option-6.patch14.46 KBrajeshreeputra

Issue fork acquia_dam-3576979

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rajeshreeputra created an issue. See original summary.

rajeshreeputra opened merge request !261

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Issue summary: View changes
Status: Active » Needs review

Currently kernel test failing, see. Skipping as handled in #3571816: MediaTypeResolver has problematic hardcoded generic media type, hence requesting review.

velmir_taky’s picture

velmir_taky commented

Nice work @rajeshreeputra! The approach for handling file extensions with download_assets is solid, and the refactored tests with data providers are really clean.

A few small things I noticed:

- Typo: file extesions => file extensions in Asset.php
- array(", ", ",") should be [", ", ","] per Drupal CS
- getFileExtensions() — simpler as return $this->configuration['file_extensions'] ?? '';

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented

Requesting review.

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
StatusFileSize
new 3576979-acquia-dam-svg-support-with-download-option-6.patch14.46 KB

Patch file.

  • rajeshreeputra committed 64d0aeeb on 1.1.x 
    Resolve #3576979 "Add file extensions support with download and sync...
rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Status: Needs review » Fixed

Merged!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

rajeshreeputra opened merge request !265

  • rajeshreeputra committed c11dc0df on 1.1.x 
    Resolve #3576979 "Support default file extensions fallback to media...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.