Problem/Motivation

An Update from 3.4.4 to 3.4.5 triggers the following error:

Circular reference detected for service "logger.channel.default", path: "asset.js.collection_optimizer -> asset.js.optimizer -> logger.channel.default -> logger.factory -> logger.raven -> Drupal\regi  
  stration\Hook\RegistrationEntityHooks -> plugin.manager.block".

I'm using Core 10.6.3.

Steps to reproduce

  1. Update to 3.4.5
  2. Call "drush cr"

Issue fork registration-3574058

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

daniel.pernold created an issue. See original summary.

daniel.pernold’s picture

daniel.pernold commented
Issue summary: View changes
daniel.pernold’s picture

daniel.pernold commented
Issue summary: View changes
daniel.pernold’s picture

daniel.pernold commented
Issue summary: View changes

nidhish made their first commit to this issue’s fork.

nidhish’s picture

nidhish commented
Assigned: Unassigned » nidhish
john.oltman’s picture

john.oltman commented

Thanks @daniel.pernold. You don't have a customized version of the Raven module's logger class by chance? I'm trying to figure out how the Raven logger depends on the entity hooks in the Registration module, which is what your trace implies. Installing the raven module, upgrading to Registration 3.4.5 and then clearing cache does not trigger the error in my 10.3.6 install.

dgwolf’s picture

dgwolf commented

Hi John, here a similar message was triggered by drush updatedb:status after an upgrade from 10.6.2 to 10.6.3 when upgrading registrations:

In Container.php line 222:
Circular reference detected for service "Drupal\registration\Hook\RegistrationEntityHooks", path: "entity_reference_revisions.orp
han_purger -> date.formatter -> Drupal\registration\Hook\RegistrationEntityHooks -> plugin.manager.menu.local_task -> Drupal\regi
stration\Hook\RegistrationEntityHooks".

john.oltman’s picture

john.oltman commented

Thanks @dgwolf. Seems I'll have to avoid injecting the block manager and task manager. I'll do that and then have a 3.4.6 release.

john.oltman’s picture

john.oltman commented
Title: Circular reference detected » Avoid circular references
Assigned: nidhish » john.oltman

john.oltman opened merge request !183

john.oltman’s picture

john.oltman commented
Assigned: john.oltman » Unassigned
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

daniel.pernold’s picture

daniel.pernold commented

Hi @john.oltman,

Thanks for investigating. Unfortunately, with version 1.4.6 I'm now getting the same error:

Circular reference detected for service "logger.channel.default", path: "asset.js.collection_optimizer -> asset.js.optimizer -> logger.channel.default -> logger.factory -> logger.raven -> Drupal\regi  
  stration\Hook\RegistrationEntityHooks -> registration.manager -> router.route_provider -> cache_tags.invalidator -> plugin.manager.block".

We are using Raven 6.0.16 in a Drupal 10.6 environment.

daniel.pernold’s picture

daniel.pernold commented

No problem with Registration 3.4.4, by the way.

john.oltman’s picture

john.oltman commented

Thanks @daniel. I know what the issue is and will do a 3.4.7 release this evening. Sorry about that. Similar problem as before, I just need to remove additional classes from injection.

john.oltman’s picture

john.oltman commented

Opened this new issue #3575255: Avoid dependency injection in entity hooks since this one is Fixed and part of a release already. Let's continue our discussion in that issue. Thanks!

dgwolf’s picture

dgwolf commented

Just my 2ct, in D10.6.3 without interfering modules the update did work, if that's of any relevance.

john.oltman’s picture

john.oltman commented

Thanks Andreas, good to know. I did do the 3.4.7 release already to be on the safe side, since there are probably more sites like Daniel's out there.

dgwolf’s picture

dgwolf commented

Just updated registration and registration_waitlist on my live 10.6.3 site from 3.4.4 to 3.4.7 and it went well. Thanks!

daniel.pernold’s picture

daniel.pernold commented

Thanks, works!

ryan-l-robinson’s picture

ryan-l-robinson commented

I just tried updating to 3.4.8 and still have a variation of this:

Circular reference detected for service "Drupal\Core\Logger\LoggerChannelFactoryInterface", path: "scheduler.manager -> logger.channel.scheduler -> Drupal\Core\Logger\LoggerChannelFactoryInterface -> logger.stdout -> Drupal\registration\Hook\RegistrationMailHooks -> token -> cache_tags.invalidator -> plugin.manag
er.block -> logger.channel.default".

john.oltman’s picture

john.oltman commented

Thanks @ryan I'll do a 3.4.9 tonight

john.oltman opened merge request !186

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.