Problem/Motivation

When using Drupal 11's navigation module, the Commerce menu item in the
toolbar appears without an icon, unlike core menu items (Structure,
Appearance, Configuration, etc.). This creates an inconsistent user experience
in the navigation toolbar.

The navigation module automatically looks for icons but Commerce doesn't
currently define any icon pack or specify an icon in its menu link definition.

Proposed resolution

Add support for the navigation module's icon system by:

1. Creating a commerce.icons.yml file to register the Commerce icon pack
2. Updating commerce.links.menu.yml to specify the cart icon for the main
Commerce menu link

Commerce already includes cart SVG icons in the icons/000000/ directory that
can be reused for this purpose.

Steps to reproduce

1. Install Drupal 11 with the navigation module enabled
2. Install Commerce 3.x
3. Navigate to the admin toolbar
4. Observe that Commerce menu item lacks an icon while other items have icons

Additional context

The cart icon already exists in icons/000000/cart.svg and is suitable for
representing Commerce in the navigation toolbar.

CommentFileSizeAuthor
#2 Screenshot 2025-12-31 at 11.24.48 AM.png10.59 KBandyg5000
#2 Screenshot 2025-12-31 at 11.25.16 AM.png10.52 KBandyg5000

Issue fork commerce-3565263

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andyg5000 created an issue. See original summary.

andyg5000’s picture

andyg5000
Primary language English
Location North Carolina, USA
commented
StatusFileSize
new Screenshot 2025-12-31 at 11.25.16 AM.png10.52 KB
new Screenshot 2025-12-31 at 11.24.48 AM.png10.59 KB
andyg5000’s picture

andyg5000
Primary language English
Location North Carolina, USA
commented
Status: Active » Needs review

See before/after screenshots for the updates.

andyg5000 opened merge request !583

jsacksick’s picture

jsacksick commented

Thank you for this.
What is "cart" referring to from commerce.links.menu.yml:

  options:
    icon:
      pack_id: commerce
      icon_id: cart

I don't see a cart identifier in the commerce.icons.yml.
I'm surprised by the test failures that seem unrelated, but those tests aren't failing in dev which is a bit odd.

stefan.korn made their first commit to this issue’s fork.

stefan.korn’s picture

stefan.korn
Primary language German
Location Jossgrund
commented

@jsacksick: cart is referencing an svg icon with file name cart in directory icons/000000/
as per config in commerce.icons.yml

  config:
    sources:
      - icons/000000/*.svg

majmunbog made their first commit to this issue’s fork.

majmunbog’s picture

majmunbog commented

@stefan.korn It would be better to create a new icon so it matches the rest of the navigation icons as closely as possible. I’ve used the drupal-cart.svg icon with appropriate adjustments and added that in.

  • jsacksick committed 1ee2fe7e on 3.x authored by andyg5000 
    feat: #3565263 Add an icon to the navigation module

By: andyg5000
By:...
jsacksick’s picture

jsacksick commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

jsacksick’s picture

jsacksick commented

Merged, thanks everyone! Not sure why the change doesn't work for me on D10, but it does work fine on D11.

stefan.korn’s picture

stefan.korn
Primary language German
Location Jossgrund
commented

@jsacksick: API for Icon management is only D11.1.x: https://www.drupal.org/node/3490350

but there should be no regression on D10, just not showing.

@majmunbog: Yes, fine to have a new icon that aligns closely with the other icons.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.