Problem/Motivation

In display settings ID and class can be given. But they are not used in markup.

Steps to reproduce

Add ID and classes to attributes for render element.

Issue fork field_group_dl-3560679

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jan kellermann created an issue. See original summary.

jan kellermann opened merge request !4

jan kellermann’s picture

jan kellermann commented
Status: Active » Needs review

Please review and / or give feedback. Thank you :)

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Thanks, this seems like a no-brainer - can we add additional asserts/logic to the existing tests to add coverage for this functionality?
Thanks!

jan kellermann’s picture

jan kellermann commented

Yes, I do. Sorry, didnt see. Then we should enable tests in Gitlab CI also.

jan kellermann’s picture

jan kellermann commented
Status: Needs work » Reviewed & tested by the community

I added the asserts and enabled PHPUnit in Gitlab CI.

Please review and give feedback.

jan kellermann’s picture

jan kellermann commented
Status: Reviewed & tested by the community » Needs review

sry...

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Fixed

Committed - thanks for adding tests, will cut a new release with this in it

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

https://www.drupal.org/project/field_group_dl/releases/1.0.4

jan kellermann’s picture

jan kellermann commented

Thank you for your work!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.