Problem/Motivation

Track the steps needed to deprecate extension TBA from core to contrib. See Remove a core extension and move it to a contributed project of the deprecation policy.
The removal of extension Toolbar was approved in #3476882: [Policy] Move Toolbar module to contrib.

Remaining tasks

  1. Create a section on Deprecated and obsolete modules and themes to provide recommendations for sites using extension Toolbar. The recommendations are to include instructions for sites using the extension and for contributed projects that depend on then extension.
  2. Add the following to the extension info.yml file

    3. lifecycle: deprecated
    lifecycle_link: https://www.drupal.org/node/3223395#s-toolbar

  3. Add #[IgnoreDeprecations] to all tests in the extension.
  4. Add a change record and include a link the the doc page.
  5. Deprecate any library that is only used by the extension.
  6. Do a thorough search of core for any remaining references to the extension. If references are found, outside of the extension, then creates issues to remove the references.

Release notes snippet

Issue fork drupal-3560123

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

phenaproxima created an issue. See original summary.

quietone’s picture

quietone commented
Version: 11.1.x-dev » 11.x-dev
Issue summary: View changes
Status: Active » Postponed
Parent issue: » #3484850: [meta] Tasks to deprecate Toolbar module

Updating this so it follows the policy for extension deprecation.

There is work to do in the parent issue first.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone opened merge request !16668

catch’s picture

catch
he/him
Primary language English
commented
Status: Postponed » Needs work

I think this is unblocked looking at the issues in #3484850: [meta] Tasks to deprecate Toolbar module.

quietone’s picture

quietone commented
Status: Needs work » Needs review
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Very straightforward, unlike all the preparatory steps, looks great.

quietone’s picture

quietone commented

There is still #3618746: Move Toolbar uses in Announcement, User, Contextual to Toolbar to be done.

catch’s picture

catch
he/him
Primary language English
commented
Title: Deprecate the Toolbar module » [PP-1] Deprecate the Toolbar module
Status: Reviewed & tested by the community » Patch (to be ported)

Don't think we'll need to change any code here, but making it clear there's an issue in front of this one.

nicxvan’s picture

nicxvan commented

Is this supposed to be patch to be ported?

catch’s picture

catch
he/him
Primary language English
commented
Status: Patch (to be ported) » Postponed

It is not.

catch’s picture

catch
he/him
Primary language English
commented
Status: Postponed » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Needs a rebase.

catch’s picture

catch
he/him
Primary language English
commented
Title: [PP-1] Deprecate the Toolbar module » Deprecate the Toolbar module
quietone’s picture

quietone commented
Status: Needs work » Reviewed & tested by the community
Issue tags: +11.5.0 release priority

Rebased with a conflict in core/modules/toolbar/tests/src/Unit/UserToolbarLinkBuilderTest.php where it was renamed and had a #[IgnoreDeprecations] added. As it is a test file being renamed and tests are passing I am restoring the RTBC.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed b11f868b572 to main and b57f2e2f857 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • longwave committed b57f2e2f on 11.x 
    task: #3560123 Deprecate the Toolbar module

By: phenaproxima
By:...

  • longwave committed b11f868b on main 
    task: #3560123 Deprecate the Toolbar module

By: phenaproxima
By:...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

godotislate’s picture

godotislate
he/him
commented

I published the CR.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.