Problem/Motivation

Belgrade is increasingly used as a focused checkout theme, often activated only on Commerce checkout routes via Theme Switcher or recipe-based setups (e.g., Commerce Recipe: Focused Checkout).
In this mode, Belgrade is not the default site theme and may not have access to the same assumptions as when it is the primary front-end theme. Some templates, libraries, and settings rely on global configuration that isn’t present when Belgrade is used as a secondary theme.

Resulting issues:

  • Checkout pages may show a different logo than the rest of the site.
  • Site builders must duplicate logo configuration manually.
  • There is no clean region to place a branding block if a site wants consistent logo/brand presentation.
  • Recipes and theme-switcher setups cannot guarantee consistent branding without custom overrides.

Issue fork belgrade-3558654

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

zaporylie created an issue. See original summary.

zaporylie’s picture

zaporylie
he/him
Primary language Polish
commented
Issue summary: View changes

majmunbog made their first commit to this issue’s fork.

majmunbog opened merge request !66

majmunbog’s picture

majmunbog commented
Status: Active » Needs review

I've added a theme setting so Belgrade’s focused checkout can optionally reuse the default site logo instead of its own. Updated the preprocess logic to honor that toggle, falling back to Belgrade’s logo when the option is off or the default theme lacks a logo.

zaporylie’s picture

zaporylie
he/him
Primary language Polish
commented
Status: Needs review » Needs work

I tested this using the recipe mentioned in the issue summary. With the new setting enabled, the logo is always inherited from the default theme—whether it’s the theme’s built-in logo or a custom one.

However, when I disable this option and set a custom logo in the Belgrade theme settings (with Belgrade still acting as the secondary theme), the logo does not appear on the focused checkout pages.

I also checked the 3.x HEAD, and it looks like this isn’t a regression introduced by this MR but rather an existing bug in Focused Checkout.

zaporylie’s picture

zaporylie
he/him
Primary language Polish
commented
Status: Needs work » Reviewed & tested by the community

Since this is not an issue with this MR, I am moving this to RTBC. I run a few more tests with the focused checkout, and the issue I mentioned in #6 seems to only affect custom logos that are uploaded in a non-SVG format.

Surprisingly, non-SVG logos uploaded to the default theme are correctly inherited by Belgrade, when it is used as a secondary theme for the focused checkout.

zaporylie’s picture

zaporylie
he/him
Primary language Polish
commented

Created a follow-up issue in #3559050: Non-SVG logo doesn't show in focused checkout

majmunbog’s picture

majmunbog commented
Status: Reviewed & tested by the community » Needs review

I have already made a fix in this MR. Could you please review this again?
Inline SVG logo settings were causing the issue.

zaporylie’s picture

zaporylie
he/him
Primary language Polish
commented
Status: Needs review » Reviewed & tested by the community

All good now.

  • majmunbog committed 5fcfd4cd on 3.x 
    feat: #3558654 Improve Belgrade compatibility as a secondary checkout-...
majmunbog’s picture

majmunbog commented
Related issues: +#3559050: Non-SVG logo doesn't show in focused checkout
zaporylie’s picture

zaporylie
he/him
Primary language Polish
commented
Status: Reviewed & tested by the community » Fixed

Thanks

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.