Problem/Motivation

(Preliminary report)
The change here applied on 4.4.x causes messages to be double escaped (e.g.: double quotes are converted to ")

Steps to reproduce

An action that contains e.g.

return [
  'type' => 'warning',
  'message' => $this->t('Warning message with "quotes"')
];

will display as Warning message with "quotes"

Proposed resolution

TODO

Remaining tasks

TODO

User interface changes

TODO

API changes

TODO

Data model changes

TODO

CommentFileSizeAuthor
#11 3555472-11.diff7.07 KBherved

Issue fork views_bulk_operations-3555472

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

herved created an issue. See original summary.

herved’s picture

herved commented
Issue summary: View changes

ioana apetri made their first commit to this issue’s fork.

ioana apetri opened merge request !129

herved changed the visibility of the branch 3555472-regression-messages-are to hidden.

travis-bradbury’s picture

travis-bradbury commented
Status: Active » Reviewed & tested by the community

Looks good to me.

herved’s picture

herved commented
Status: Reviewed & tested by the community » Needs work

phpunit is failing

herved opened merge request !134

herved’s picture

herved commented

I created another branch and MR (134) but did not test extensively (mainly the drush part).

herved’s picture

herved commented
Status: Needs work » Needs review
herved’s picture

herved commented
StatusFileSize
new 3555472-11.diff7.07 KB

MR134 snapshot

  • joelpittet committed 200f5a0e on 4.4.x authored by herved 
    fix: #3555472 [regression] Messages are double escaped on 4.4.x after #...
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Fixed

Thank you all, that fix looks great, I have committed it to the dev branch.

I have my hands dirty in the root of this as I drove auto-escaping in D8 to start with. I am hoping the endless undouble-escaping experience I got from that hasn't degraded over time, and hope time also hasn't changed if that was a good idea..., 😅

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.