Problem/Motivation

Since we now allow placing blocks of PBs even if the source is disabled, we have introduced an issue where if you try to place a block on a disabled source, all the configuration that is expected is missing, and it whitescreens.

Steps to reproduce

Start up PB off of a normal install. (In this setup, Recipes & Contrib modules are enabled out of the box). Go to Block Layout and add a block for one of the other sources (i.e. Recommended or Local modules), and when you save that form, you go to the whitescreen.

Proposed resolution

Allow a disabled block to be configured and placed, and just ensure it doesn't render anything.

Issue fork project_browser-3553019

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chrisfromredfin created an issue. See original summary.

tim.plunkett made their first commit to this issue’s fork.

tim.plunkett opened merge request !877

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Active » Needs work
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Issue tags: +backport

This should definitely be backported to 2.0.x.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Didn't manually test this, but code looks good.

Tests pass and fails as expected. Wondering if we want a test for actually placing the block, but that would be probably be testing the block system itself, so RTBC.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented

We already have a test of the block itself: https://git.drupalcode.org/project/project_browser/-/blob/2.1.x/tests/sr...

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Reviewed & tested by the community » Fixed

Fweep!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.