Problem/Motivation

Follow up issue after #3540623: Fix Various CSS and UI Issues Affecting Usability and Consistency while editing the layout with Layout Builder
Drupal core 10.4/10.5 was released, Claro in Drupal core had number of changes.
The Gin admin theme 3.1/4.1 was released with number of changes.

  • Sascha committed #3279620: RTL (right-to-left): change to logical CSS
  • Following with his logic of CSS Logical Properties in all integrations with Gin and Claro - and the front-end theme.
  • The movement for changes with Logical Properties will extend to Drupal Core and Contrib modules and themes.
  • Most of [dir="rtl"] or [dir="ltr"] selectors will be removed from CSS, SASS, PostCSS in code.

Several CSS and layout inconsistencies were observed across the Layout Builder interface that impact user experience and visual consistency. These issues affect the positioning of loading indicators, alignment of fields and menus, visibility of icons and controls, and overall UI polish. Addressing these will improve the usability and professional appearance of the Layout Builder.

  • The ring when adding a block is in a wrong spot (Maybe make it the same thing once a user click on the add block and you see a ring in the middle of the screen)
  • Fields inside the blocks sometimes are not the same length (Accordion Block for example)
  • The collapse menu items are not on the same length
  • The drag and drop icon is not visible
  • The show weights fields are not visible enough or not enough space to show them
  • The collapse all sub menu “edit all” is not on the same length
  • Once a block is saved the word “Processing” is not in a good spot
  • Style tab for the blocks, If a color is selected then the user clicks on the de-select button the whole grid will stay in gray
  • Fix the (X) button as well
  • The * icon is not in the correct place
  • The tabs are not aligned correctly with the field below it

Steps to reproduce

  • When using the Layout Builder
  • When adding sections
  • When adding blocks with modal
  • When editing/editing Accordions
  • When adding/editing Impressed card

Proposed resolution

  • Update the Gin theme build for layout builder modal
  • Update the Claro theme build for layout builder modal

  • Adjust CSS positioning for the add block ring to be consistent with the central display.
  • Standardize field width inside all blocks (including Accordion Block).
  • Align collapse menu items to a unified horizontal baseline.
  • Make the drag-and-drop icon visible with proper contrast.
  • Ensure show weights fields have enough space and visibility.
  • Align Collapse all submenu edit all option with other menu items.
  • Move Processing text to a clear and consistent position after save.
  • Reset grid background to default when deselecting a style color.
  • Correct (X) close button alignment.
  • Reposition the * required-field indicator to follow form label conventions.
  • Align tabs with the corresponding field content below.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ✅ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-10.1.0-beta1, varbase_layout_builder-10.2.0-beta3, varbase-10.0.8, varbase_layout_builder-10.1.15

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

After the fix:

vlb modal


vlb modal - accordion

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • #3547948 perf(ui): Optimization round 2 for Layout Builder modal and block editing combined styling By: n.ghunaim
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

n.ghunaim created an issue. See original summary.

n.ghunaim changed the visibility of the branch 3547948-10.1-fix-css to hidden.

n.ghunaim’s picture

Status: Active » Needs review
rajab natshah’s picture

Title: Fix Various CSS and UI Issues Affecting Usability and Consistency while editing the layout with Layout Builder - Part 2 » Optimization round 2 for Layout Builder modal and block editing combined styling
Issue summary: View changes
rajab natshah’s picture

rajab natshah’s picture

Assigned: Unassigned » s.halawani
Issue summary: View changes
Issue tags: +varbase-10.1.0-beta1, +varbase_layout_builder-10.2.0-beta3, +varbase-10.0.8, +varbase_layout_builder-10.0.66
rajab natshah’s picture

Assigned: s.halawani » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

rajab natshah’s picture

Issue summary: View changes
Issue tags: -varbase_layout_builder-10.0.66 +varbase_layout_builder-10.1.15
rajab natshah’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

✅ Released varbase-10.0.8