Describe your bug or feature request.

commerce.field_ui.css uses 000000 as the hex value for styling the cart icon for the field UI (in the add field dialog modal). that way the cart icon stands out from the rest of the icons

the add field dialog modal

Use 55565b like the icons in core or in the address module.

If a bug, provide steps to reproduce it from a clean install.

CommentFileSizeAuthor
#8 updated_cart.jpg127.13 KBrkoller
cart.jpg127.68 KBrkoller

Issue fork commerce-3540735

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rkoller created an issue. See original summary.

majmunbog made their first commit to this issue’s fork.

majmunbog’s picture

Status: Active » Needs review
jsacksick’s picture

@majmunbog: So did we just use the same color than core?

jsacksick’s picture

Version: 3.0.x-dev » 3.x-dev
majmunbog’s picture

Yes, we use the same color as core, but I've switched from loading the background image SVG to an inline SVG encoded as a data URL.

rkoller’s picture

StatusFileSize
new127.13 KB

thank you for the fast fix @majmunbog! i've checked out your changes and the cart is now in line with the rest of the icons, so output wise this looks good:

add field dialog modal

and one note, there is currently work happening to improve the microcopy of the "add field" dialog modal (see #3370326: Refine labels and descriptions for field types - comment #72 there lead me to install commerce and noticing the icon color issue as an aside). i'll open up follow up issues in the address and commerce queues as soon as there is a consensus and issue close to being fixed. cuz it would be good to adjust the micro copy for address and commerce field types to the patterns proposed for core as well (perhaps a style guide is needed after all as an artifact of #3370326: Refine labels and descriptions for field types)

  • jsacksick committed cf266ed0 on 3.x authored by majmunbog
    Issue #3540735 by majmunbog, rkoller, jsacksick: Adjust the color of the...
jsacksick’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.