Problem/Motivation

There is no CI for the module.

Steps to reproduce

No steps to reproduce.

Proposed resolution

Implement Drupal CI into this module.

Remaining tasks

Configure .gitlab-ci.yml using Drupal templates.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork extrafield_views_integration-3536338

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

konot created an issue. See original summary.

konot opened merge request !4

bohart’s picture

bohart
Location Lutsk, Ukraine
commented
Version: 2.1.0 » 2.x-dev
Priority: Normal » Minor

Just a quick overview:

1) cspell

The number of distinct unrecognised/misspelled words is 2
------------
doesn
extrafields

There is no much sense in creating separate issues to address those further.
We need to fix "doesn't" and to add "extrafields" to cspell allow a list of the module in this PR (as this is really quick fix to make this step green).

2) The same with phpcs - "Missing short description in doc comment"
This is a one-line and a few-second fix. I think it should be done here as well (with no additional issues).

Thanks!

konot’s picture

konot commented
Assigned: konot » Unassigned
Status: Active » Needs review

I have added the CI for the module. To eliminate existing warnings from lints, I have:
1. Included extrafields in _CSPELL_WORDS.
2. Added the phpstan-baseline.neon file to ignore warnings about missing return statements.
3. Corrected some typos in the code.

For now, the lints are functioning well.

  • bohart committed 880938f5 on 2.2.x authored by konot 
    Issue #3536338 by konot, bohart: Added Gitlab CI pipelines.

bohart credited abramm.

bohart’s picture

bohart
Location Lutsk, Ukraine
commented
Version: 2.x-dev » 2.2.x-dev
Component: Miscellaneous » Code
Status: Needs review » Fixed

Thanks @konot for your contribution!

As for now:
- A new branch 2.2.x has been created.
- A new dev release 2.2.x-dev has been created.
- The current changes are committed to this new branch.

Those changes will be a part of a new stable release within #3430393: Automated Drupal 11 compatibility fixes for extrafield_views_integration.
Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.