Problem/Motivation

This is a follow-up issue from #3530945: Remove gin_toolbar (and toolbar) from drupal_cms_admin_ui. We should try and remove the dependency from the toolbar module if possible.

When navigation is enabled, the toolbar module should be disabled.

When navigation is disabled, the toolbar module should be enabled.

Proposed resolution

Use hooks for installed and uninstalled modules as well as for requirements handling.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

jurgenhaas created an issue. See original summary.

jurgenhaas’s picture

Turns out, the solution is even simpler than that: there are only 2 places where the code depends on the toolbar module, and they can be called conditionally and all should be fine. That way, it's down to the user, if they want to enable the toolbar module or not.

jurgenhaas’s picture

Status: Active » Needs review

  • jurgenhaas committed a4491c8c on 3.0.x
    Issue #3531236 by jurgenhaas: Remove dependency from toolbar module
    
jurgenhaas’s picture

Status: Needs review » Fixed

Got a good to go on Slack.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

stefan.korn’s picture

Shouldn't there still be at least a hint somewhere (README?) that the toolbar module is required if gin toolbar is used without the navigation module? Or if technically not required, than something like a hint the toolbar module enhances the functionality of gin toolbar as long as navigation module is not enabled.

Currently with a minimal installation and just enabling Gin Toolbar nothing seems to happen. Some background things like style injections may still happen, but the toolbar itself is not visible. The toolbar only gets visible after enabling the toolbar module.

And if

When navigation is enabled, the toolbar module should be disabled.

When navigation is disabled, the toolbar module should be enabled.

is valid, why does the warning about that is surpressed from #3489361: Status warning: Toolbar and Navigation modules are both installed?

May well be, that I am misunderstanding something here, but am bit puzzled about this now.