Overview

found in #3526907: For content entities add client support conflict detection via the `autoSaves' key
ApiLayoutController::buildPreviewRenderable() always auto-saves regions regardless of $updateAutoSave value

This might be needed but we should have a note why this is

Proposed resolution

Either add a comment as to why this is needed or fix

User interface changes

Issue fork experience_builder-3530857

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tedbow created an issue. See original summary.

tedbow opened merge request !1159

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Active » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Component: Page builder » Auto-save
Status: Needs review » Reviewed & tested by the community

This bug was introduced in #3492061: Include the preview HTML in the layout controller payload, i.e. where $updateAutoSave was introduced.

This seems like a trivial, innocent oversight. Requiring test coverage for this seems overkill.

Nice one, @tedbow!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

  • wim leers committed 0819fbfd on 0.x authored by tedbow 
    Issue #3530857 by tedbow, wim leers: ApiLayoutController::...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

This conflicted with #3529622: Make auto-save manager only support passing and returning entity objects, remove support for arbitrary data, use deterministic hashing to ensure entries are actually updates but I had made the same change there and that's what it conflicted on - nice!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#3529622: Make auto-save manager only support passing and returning entity objects, remove support for arbitrary data, use deterministic hashing to ensure entries are actually updates

Nice indeed! 😄

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.