Problem/Motivation

I had to put in a patches-ignore entry into my build to upgrade

Patch we are using was committed, issue marked as fixed
#2834253: Missing column headings in Revisions list

Steps to reproduce

composer up

Proposed resolution

pin wxt 5.4.x and 6.1.x on new minimal value for diff module

Remaining tasks

Review

Comments

joseph.olstad created an issue. See original summary.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Category: Bug report » Support request

Support request but could be also considered a bug.

affects 5.4.x and also 6.1.x

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Category: Support request » Bug report
Related issues: +#2834253: Missing column headings in Revisions list

Here's what worked over here:

        "patches-ignore": {
            "drupalwxt/wxt": {
                "drupal/diff": {
                    "Diff module patch no longer needed with latest release: https://www.drupal.org/project/wxt/issues/3530570":
                    "https://www.drupal.org/files/issues/2024-05-09/diff-missing_column_headers-2834253-23.patch"
                }
            }
        }
smulvih2’s picture

smulvih2
Location Canada 🍁
commented

Ahh ok, have been waiting for a long time for this patch to get included in a release. Will remove this patch in 5.4.x and push out a new release. It's also being used in 6.1.x so will do the same there as well. Thanks for reporting this!

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

One for 5.4.x

https://github.com/drupalwxt/wxt/pull/328

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

another for 6.1.x

https://github.com/drupalwxt/wxt/pull/329

  • smulvih2 committed 6c8b537f on 6.1.x 
    Issue #3530570 by joseph.olstad, colan, smulvih2: diff module patch no...

  • smulvih2 committed a0c58d62 on 5.4.x 
    Issue #3530570 by joseph.olstad, colan, smulvih2: diff module patch no...
smulvih2’s picture

smulvih2
Location Canada 🍁
commented
Status: Active » Fixed

This has been included with release 6.1.1 and 5.4.3.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.