Problem/Motivation

In the Gin admin theme of the current Drupal CMS edition the save_edit button is hidden inside a menu... see screenshot.
How can I get it out of there?

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 1749852615.png16.02 KBcaesius
2025-06-07_12h43_12.png30.41 KBmaxilein

Comments

maxilein created an issue. See original summary.

maxilein’s picture

maxilein commented
Related issues: +#3458569: Support Gin Admin theme's MoreActions button, +#3508072: Latest Gin admin theme button in "more actions" dropdown
maxilein’s picture

maxilein commented

If I change save_edit.module line 57:

     if ($config->get('gin_primary')) {
        $form['actions']['save_edit']['#gin_action_item'] = TRUE;
      }

to 

      /*if ($config->get('gin_primary')) {*/
        $form['actions']['save_edit']['#gin_action_item'] = TRUE;
      /*}*/

it works and is visible alongside the save button.

maxilein’s picture

maxilein commented

Whatever this line does
if ($config->get('gin_primary')) {: Maybe the problem is that I use gin for admin theme (not main theme) and to edit content?

caesius’s picture

caesius commented
Related issues: +#3461404: The "Save & Edit" button is hidden behind a "More actions" dropdown button in the Gin Admin theme

Hi, please review this related issue: #3461404: The "Save & Edit" button is hidden behind a "More actions" dropdown button in the Gin Admin theme

This code was added because the button was hidden in the Gin theme. Now you're saying that with this code the button gets hidden?

Please track down what specific version of the Gin theme this code worked on, and when it broke. Or see if it breaks in Drupal CMS but is fine in vanilla Drupal.

If it breaks from a minor or patch update of the Gin admin theme, then I'd be fine removing all the Gin-related code from the module. However, if it only breaks on a major version update of the Gin theme, then I'd only be comfortable removing the code on a 2.0 release of this module in order to avoid breaking sites that haven't upgraded Gin yet.

Either way I think moving forward I will not be accepting theme-specific accommodations for this module and would suggest custom code or a new submodule to deal with any issues a specific theme presents for the Save & Edit button (aside from Claro).

caesius’s picture

caesius commented
Status: Active » Postponed (maintainer needs more info)
maxilein’s picture

maxilein commented
Version: 8.x-1.x-dev » 8.x-1.8

Sorry I was in the wrong. I used Version: 8.x-1.8 not the current dev version of save_ edit.
But the current dev has the same date. It made no change. I had to leave the check commented.

caesius’s picture

caesius commented
StatusFileSize
new 1749852615.png16.02 KB

I installed the latest version of Save & Edit on Drupal 11.

The Save & Edit button appears as a primary button (not under "More Actions") if this configuration is enabled:

screenshot

@maxilein did you enable this configuration option? (after uncommenting the module code)

caesius’s picture

caesius commented
Version: 8.x-1.8 » 8.x-1.x-dev
Component: Code » User interface
caesius’s picture

caesius commented
caesius’s picture

caesius commented
Assigned: Unassigned » caesius
Category: Bug report » Feature request
Status: Postponed (maintainer needs more info) » Needs work

I'm adding code to the .install file to enable the above configuration option by default if Gin is the admin theme upon module installation.

  • caesius committed ccb76b6f on 8.x-1.x 
    Issue #3528935 by maxilein, caesius: Save_edit in GIN admin theme in...
caesius’s picture

caesius commented
Status: Needs work » Fixed

Fixed in 8.x-1.9 and 2.0.0-rc2

  • caesius committed ccb76b6f on 2.x 
    Issue #3528935 by maxilein, caesius: Save_edit in GIN admin theme in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.