Problem/Motivation

On node edit forms with the Gin Admin theme the "Save & Edit" button is hidden behind a secondary actions dropdown button with the title "More actions". In all projects where I have this module installed, after the latest update of the Gin Admin theme, editors have reported that it is annoying that the button is hidden on the form by default requiring an extra action to save the node.

Steps to reproduce

  1. Install and use as default admin theme the Gin Admin theme
  2. Create or edit a node.
  3. Check that "Save & Edit" button is hidden behind a secondary actions dropdown button.

Proposed resolution

In the "Save & Edit" configuration form it could be checked if the Gin Admin theme is installed and if so, display a setting to show the button in primary actions of the Gin Admin theme, which if activated, adds the button to these primary actions. By default, whether the theme is installed or not, the value of this setting will be FALSE.

CommentFileSizeAuthor
#2 3461404-2.patch3.82 KBenchufe

Issue fork save_edit-3461404

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

enchufe created an issue. See original summary.

enchufe’s picture

Status: Needs work » Needs review
StatusFileSize
new3.82 KB

Proposed solution applied in a patch.

enchufe’s picture

Assigned: enchufe » Unassigned

caesius made their first commit to this issue’s fork.

caesius’s picture

caesius’s picture

Status: Needs review » Reviewed & tested by the community

Tested in both Gin and non-Gin admin themes, as well as with Gin as the default theme and "Use the administration theme when editing or creating content" unchecked.

Also tested that update hook works as expected.

This looks good to go.

caesius’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mostepaniukvm’s picture

It's again an issue after update to gin 8.x-3.0-rc14
Don't see #gin_action_item key in Gin's codebase anymore. Needs work again

caesius’s picture

Status: Closed (fixed) » Needs work
mostepaniukvm’s picture

Status: Needs work » Needs review

It was added back in the related issue #3486743: Cannot opt out buttons using #gin_action_item = TRUE.
Meanwhile, use the patch from the issue with Gin 8.x-3.0-rc14.
I'm not sure if we need to do anything further in this issue.

caesius’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.