Problem/Motivation

#3526581: Have all Varbase Components in the Vartheme BS5 starterkit theme
#3526576: Remove all components as they were moved to Vartheme BS5 starterkit theme

Proposed resolution

  • Change the View Modes Inventory Factory to work with DEFAULT_ACTIVE_THEME token to replace it with the default active theme.
  • Change Config Templates to have DEFAULT_ACTIVE_THEME
  • Remove hard coded varbase_components or vartheme_bs5.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release vmi-4.0.0-alpha4

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3527225 by ahmad.estaitia: Changed config templates in VMI to use the DEFAULT_ACTIVE_THEME token for used components with UI Patterns ~2.0 instead of the old Varbase Components direct use logic

Issue fork vmi-3527225

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ahmad.estaitia created an issue. See original summary.

ahmad.estaitia opened merge request !3

ahmad.estaitia’s picture

ahmad.estaitia commented
Status: Needs work » Needs review
rajab natshah’s picture

rajab natshah
he/him
commented
Title: Change config ui patterns to use vartheme components instead of varbase components » Change config templates for UI Patterns to use the DEFAULT_ACTIVE_THEME token for components instead of Varbase Components
rajab natshah’s picture

rajab natshah
he/him
commented
Title: Change config templates for UI Patterns to use the DEFAULT_ACTIVE_THEME token for components instead of Varbase Components » Change config templates for VMI to use the DEFAULT_ACTIVE_THEME token for components with UI Patterns ~2.0 instead of Varbase Components directly
ahmad.estaitia’s picture

ahmad.estaitia commented

Added attribution

rajab natshah’s picture

rajab natshah
he/him
commented
Title: Change config templates for VMI to use the DEFAULT_ACTIVE_THEME token for components with UI Patterns ~2.0 instead of Varbase Components directly » Change config templates in VMI to use the DEFAULT_ACTIVE_THEME token for used components with UI Patterns ~2.0 instead of the old Varbase Components direct use logic

rajab natshah’s picture

rajab natshah
he/him
commented

1- Fixed the Get the default active theme to use $this->configFactory->get('system.theme')->get('default');

2- Fixed Drupal Standard and Drupal Practice issues

rajab@vardot-dev:/var/www/html/products/vmi$ phpcs --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,less,css,info,txt,md,yml,js /var/www/html/products/vmi/ --ignore=/var/www/html/products/vmi/node_modules/

rajab@vardot-dev:/var/www/html/products/vmi$ phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,less,css,info,txt,md,yml,js /var/www/html/products/vmi/ --ignore=/var/www/html/products/vmi/node_modules/

Basic check with yarn phpcs and basic fixes with yarn phpcbf

  • rajab natshah committed 710cd8f1 on 4.0.x 
    Issue #3527225: Fix code to get default theme via configFactory and...
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: Unassigned » s.halawani
Issue summary: View changes
Issue tags: +vmi-4.0.0-alpha4
rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: s.halawani » Unassigned
Status: Needs review » Fixed
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes

✅ Released vmi-4.0.0-alpha4

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.