Problem/Motivation

The CKEditor 5 table implementation currently lacks several key plugins, including:

  1. Table Properties (ckeditor5_table_properties)
  2. Table Cell Properties (ckeditor5_table_cell_properties)
  3. Cell Merging (ckeditor5_table)
  4. Column Management (ckeditor5_table)
  5. Row Management (ckeditor5_table)

Varbase CKEditor
varbase

CKEditor-5 DEMO
ckeditor

Steps to reproduce

  1. Fresh varbase install
  2. Check the rich text field

Proposed resolution

1- Have a better fix for both Tables and Resize Image at the same time
2- Add the following styles for tables

table.table.table-striped|Table Striped
table.table.table-hover|Table hover
table.table.table-bordered|Table Bordered

Projects can add more of these Table styles to match any of Table variants in this Varbase Storybook link
https://storybook.demo.varbase.vardot.com/?path=/docs/molecules-table--docs


Bootstrap Documentation on Tables

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ❌ Release varbase-10.1.1, varbase_editor-10.1.1, varbase-10.0.9, varbase_editor-10.0.20

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

After the fix:

Table selected in the CKEditor

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

ahmad khader created an issue. See original summary.

ahmad khader’s picture

This patch addresses issues with plugins related to ckeditor5_table. However, as previously discussed with @rajab, the ckeditor5_table_cell_properties and ckeditor5_table_properties plugins are incompatible with the allowed HTML filter. This incompatibility stems from the core filter's restriction on the 'style' attribute, which is implemented within the allowed HTML configuration to mitigate potential cross-site scripting vulnerabilities.

rajab natshah’s picture

Title: CKEditor 5 lacks table configuration options. » Fix hidden CKEditor 5 table configuration options
rajab natshah’s picture

Issue summary: View changes
Status: Needs review » Needs work
rajab natshah’s picture

Assigned: Unassigned » rajab natshah
Status: Needs work » Active
rajab natshah’s picture

Title: Fix hidden CKEditor 5 table configuration options » Hidden CKEditor 5 table configuration options

rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

✅ Released varbase-10.0.9

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.