Problem/Motivation

CSS variables related to Gin were fixed in the release 2.1.1 (containing only changes from the issue https://www.drupal.org/project/autocomplete_deluxe/issues/3511651).

The provided fix has a faulty CSS property value (unclosed var(): background-color: var(--gin-color-primary-light-hover;) for background-color. When CSS/JS is being aggregated, this will cause multiple issues on the site. Paragraph creation widget and admin_toolbar to name a few.

autocomplete_deluxe issue with CSS aggregation

Steps to reproduce

- Install admin_toolbar and latest autocomplete_deluxe
- Enable CSS/JS aggregation for the site
- Configure autocomplete_deluxe widget for a content type
- See the node form and the issue revealing itself

Proposed resolution

Fix the broken value.

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ✅ Testing to ensure no regression
  • ➖ Automated unit testing coverage
  • ➖ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ➖ Readability
  • ➖ Accessibility
  • ➖ Performance
  • ➖ Security
  • ➖ Documentation
  • ✅ Code review by maintainers
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Release notes snippet
  • ❌ Release autocomplete_deluxe-2.1.2

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

CommentFileSizeAuthor
#3 autocomplete_deluxe-aggregation-broken-3512207-3.diff630 bytesisampo
autocomplete_deluxe-2.1.1-broken.png129.73 KBisampo

Issue fork autocomplete_deluxe-3512207

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

isampo created an issue. See original summary.

isampo opened merge request !26

isampo’s picture

isampo commented
Status: Active » Needs review
StatusFileSize
new autocomplete_deluxe-aggregation-broken-3512207-3.diff630 bytes

MR open. Patch included for composer patching.

shortspoken’s picture

shortspoken commented

Thanks for the patch. Can confirm this solves the issue. Best way would be to solve it directly in the .scss file though. Will see what we can do.

rajab natshah’s picture

rajab natshah
he/him
commented
Title: Version 2.1.1 breaks parts of the site when CSS aggregation is enabled » Fix broken CSS variable which causing UI issues when CSS aggregation is enabled

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: isampo » Unassigned
Status: Needs review » Fixed
Issue tags: +autocomplete_deluxe-2.1.2
Related issues: +#3511651: Fix Gin custom CSS not working in version 3.x due to outdated variable notation
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes

✅ Released autocomplete_deluxe-2.1.2

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.