Problem/Motivation
The current autocomplete_deluxe.gin.css uses old gin variable notation - before #3309113: Change CSS3 variables from camelCase to kebab-case landed, which was on September 20, 2022 at 15:59:22 GMT+2.
It further uses mask-image: icon('close'); which makes it seem like this was manually converted from a scss source?
Oddly enough there's no /assets/scss/autocomplete_deluxe.gin.scss to be found in the source code either.
Proposed resolution
Update css variable naming and fix usage of icon().
Remaining tasks
- ✅ File an issue
- ✅ Addition/Change/Update/Fix
- ✅ Testing to ensure no regression
- ➖ Automated unit testing coverage
- ➖ Automated functional testing coverage
- ➖ UX/UI designer responsibilities
- ✅ Readability
- ✅ Accessibility
- ➖ Performance
- ➖ Security
- ➖ Documentation
- ✅ Code review by maintainers
- ✅ Full testing and approval
- ✅ Credit contributors
- ✅ Review with the product owner
- ✅ Release notes snippet
- ❌ Release autocomplete_deluxe-2.0.8, autocomplete_deluxe-2.1.1
API changes
- N/A
Data model changes
- N/A
Release notes snippet
Issue fork autocomplete_deluxe-3511651
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
das-peter commentedComment #4
rajab natshahComment #7
rajab natshahComment #8
rajab natshahComment #9
rajab natshah✅ Released autocomplete_deluxe-2.0.8
Comment #10
rajab natshah✅ Released autocomplete_deluxe-2.1.1
Comment #11
das-peter commentedAwesome! Thanks for your quick reaction!
Comment #12
rajab natshahThank you, Peter, for filing the issue and the MR.
Comment #13
rajab natshahFacing the following follow up issue #3512207: Fix broken CSS variable which causing UI issues when CSS aggregation is enabled
Comment #14
rajab natshah✅ Released autocomplete_deluxe-2.1.2