Problem/Motivation

PHP 8.4 has deprecated implicit nullable types.

Steps to reproduce

Use in a PHP 8.4 environment

Proposed resolution

Use explicit nullable types (compatible with PHP 7.1+ so no compatibility concerns given Drupal core PHP minimums)

CommentFileSizeAuthor
#10 address-1-12-3509308.patch2 KBkiseleva.t
#9 address-3509308.patch2.4 KBklausi

Issue fork address-3509308

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

beloglazov91 created an issue. See original summary.

beloglazov91’s picture

beloglazov91
he/his
commented
Version: 2.1.x-dev » 2.0.x-dev

beloglazov91 changed the visibility of the branch 3509308-nullable-types-must to hidden.

beloglazov91 opened merge request !67

beloglazov91’s picture

beloglazov91
he/his
commented
Status: Active » Needs review

liam morland made their first commit to this issue’s fork.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Issue tags: +PHP 8.4

I added one more explicit null declaration and tests now pass on max PHP. I have reviewed the other commit and I agree that it is the correct change.

mlncn’s picture

mlncn commented
Status: Needs review » Reviewed & tested by the community

Looks good (i've looked at a lot of these lol) and works, thank you! As noted already in the issue summary there are no compatibility concerns given Drupal core's minimum PHP requirements.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
StatusFileSize
new address-3509308.patch2.4 KB

Uploading stable patch file for composer patches.

kiseleva.t’s picture

kiseleva.t commented
StatusFileSize
new address-1-12-3509308.patch2 KB

Rerolled patch for 1.12.

jsacksick made their first commit to this issue’s fork.

jsacksick’s picture

jsacksick commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.