Problem/Motivation

1. When enabling the module via drush the following error is encountered:

 [success] Module simple_sitemap has been installed. (Permissions - Configure)

In RouteProvider.php line 211:
                                                         
  Route "simple_sitemap.settings_views" does not exist.

Error is caused by the route named in the `configure` property of `simple_sitemap_views.info.yml` not matching routing.yml. Also note that the naming pattern does not match other sub-modules

Proposed resolution

1. Update the settings route name to be consistent with other submodules to `simple_sitemap_views.settings`
2. Make route consistent in both routing file and info file

Issue fork simple_sitemap-3507718

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

richardgaunt created an issue. See original summary.

richardgaunt’s picture

richardgaunt commented

Added fix to Issue fork https://git.drupalcode.org/issue/simple_sitemap-3507718

richardgaunt’s picture

richardgaunt commented
Status: Active » Needs review

richardgaunt opened merge request !123

richardgaunt’s picture

richardgaunt commented

Added a Merge request for easy review: https://git.drupalcode.org/project/simple_sitemap/-/merge_requests/123

richardgaunt’s picture

richardgaunt commented
Assigned: richardgaunt » Unassigned

walkingdexter made their first commit to this issue’s fork.

walkingdexter closed merge request !123

walkingdexter opened merge request !124

  • walkingdexter committed 75b8fd42 on 4.x 
    Issue #3507718 by richardgaunt, walkingdexter: Error on installing /...
walkingdexter’s picture

walkingdexter commented
Version: 4.2.2 » 4.x-dev
Status: Needs review » Fixed

Thanks for the issue! The proposed resolution is a breaking change, so I just fixed the info files.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.