Problem/Motivation

After update voting_api to 4.x I can't unvote my votes. I get:

TypeError: Drupal\votingapi\VoteResultFunctionManager::recalculateResults(): Argument #3 ($vote_type) must be of type string, null given, called in /var/www/web/modules/contrib/votingapi_reaction/src/VotingApiReactionManager.php on line 223 в Drupal\votingapi\VoteResultFunctionManager->recalculateResults() (строка 117 из /var/www/web/modules/contrib/votingapi/src/VoteResultFunctionManager.php)

Steps to reproduce

Update voting_api to 4.x on existing site. Try to unvote any vote.

Proposed resolution

Update the code. This works both voting_api 3.x and 4.x

CommentFileSizeAuthor
#4 votingapi_reaction--2025-07-16--mr-9.patch1.84 KBmichal.magdziarek

Issue fork votingapi_reaction-3505503

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ivnish created an issue. See original summary.

ivnish opened merge request !9

ivnish’s picture

ivnish
he/him
commented
Assigned: ivnish » Unassigned
Status: Active » Needs review

The new code does not affect the pipeline warnings

michal.magdziarek’s picture

michal.magdziarek commented
StatusFileSize
new votingapi_reaction--2025-07-16--mr-9.patch1.84 KB

Attached a static patch file for this point

elaman made their first commit to this issue’s fork.

  • elaman committed 54e51262 on 8.x-1.x authored by ivnish 
    Issue #3505503 by ivnish: Can not unvote after update voting_api to 4.x
elaman’s picture

elaman
Primary language English
Location Philadelphia, United States
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.