Overview

#3484678: Simplify ComponentSourceInterface::getClientSideInfo(), introduce ClientSideRepresentation value object, and leverage it change the label for block components but didn't update the corresponding e2e test

Proposed resolution

Update the test

User interface changes

Issue fork experience_builder-3500111

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

larowlan created an issue. See original summary.

larowlan opened merge request !553

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Assigned: Unassigned » wim leers
Status: Active » Needs review

Note I've also bundled this into #3495752: Send page data to Drupal for storage in auto-save store

wim leers made their first commit to this issue’s fork.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » Unassigned
Status: Needs review » Reviewed & tested by the community
Issue tags: +e2e, +DX (Developer Experience)

I cannot approve/land #3500136: Random failure in empty-canvas.cy.js nor #3500128: Random failure in component-operations.cy.js, so removed those from the MR.

I can approve 90% of what the remaining MR changes (reason: https://git.drupalcode.org/project/experience_builder/-/merge_requests/5...), but it does include an intercept too, which is why I cannot sign off on those other tests. Deciding to merge this one because https://git.drupalcode.org/project/experience_builder/-/merge_requests/5...

  • wim leers committed 411c854f on 0.x authored by larowlan 
    Issue #3500111 by larowlan: HEAD test failure on global-region.cy.js
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.