Closed (fixed)
Project:
Experience Builder
Version:
0.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
16 Jan 2025 at 02:28 UTC
Updated:
4 Feb 2025 at 19:54 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #3
larowlanAlso included this in #3500111: HEAD test failure on global-region.cy.js
Comment #4
wim leersNeeds Cypress expertise to review, due to the introduction of waits and an intercept, which I thought we eliminated? 🤔
Comment #5
bnjmnmI believe this is similar to my comment in #3500136: Random failure in empty-canvas.cy.js where there are waits being added for endpoints to address the issue, but the problem occurs slightly earlier so those endpoints are not being requested at all.
Comment #6
larowlanGot this twice on #3490087: Controllers performing data modification should make use of CSRF tokens via /session/token today
Comment #7
larowlan@bnjmnm I think the first wait is valid here, because the newly added component doesn't yet show in the sections library.
The second one is the same as your comment on #3500136: Random failure in empty-canvas.cy.js I agree. Either way, it's costing us velocity
Comment #8
larowlanGot this twice on #3500087: Make AutoSaveManager::getAutoSaveKey static today too
Comment #9
bnjmnmThis seems to be reliably passing with the changes I made in #3500542: Implement adding component to empty layout without dnd. It's difficult to be 100% sure since it is intermittent but I re-ran the tests many times and it's green every time
Comment #10
wim leers#3500542: Implement adding component to empty layout without dnd has been merged.
But … #9: I found a remaining random failure, that is not related to drag-and-drop:
— #3500542-9: Implement adding component to empty layout without dnd
Comment #11
bnjmnmcomponent-operations had two different random fail areas, one of which was recently addressed in #3500542: Implement adding component to empty layout without dnd. The other, which happens to be the screenshot in the issue summary, has something pretty specific going on.
It fails when looking for a section called "The Entire Node 1". In the issue summary, that section is instead namede "Node 1"
In a separate instance of this failing, the section is named "e Node 1"
This is the code where it happens - the input is receptive enough to receive the
clear()as there are no artifacts of the default section name "Two Column section", but it looks like the fails occur when some of the initial typing used to name the section fails to register.It is a pretty specific way to fail so hopefully that means a fix is reasonably easy to achieve too.
Comment #13
bnjmnmFortunately I was able to reproduce the flaky test locally by slowing things down a bit (throttling or enabling Xdebug worked). The
3500128-retry-typing-until-it-worksbranch has the solution, and I've re-run it several times. It being intermittent makes it hard to be 100% certain, but this fixing it on a local where it happened reliablyComment #14
hooroomooComment #16
hooroomooComment #17
hooroomoo