Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Overview
Title says it all mostly: let's also reorder the entries in both *.routing.ymland /openapi.yml to be alphabetically sorted.
(@traviscarden initially did that over at #3486203: Integrate saving sections with the backend: (de)normalize Pattern config entities using the client-side data model.)
Proposed resolution
Do it. Test it to ensure it does not regress.
Refactor the most obvious inconsistencies away with perfect confidence thanks to the new guardrails the aforementioned test coverage added:
- https://git.drupalcode.org/project/experience_builder/-/merge_requests/6...
- https://git.drupalcode.org/project/experience_builder/-/merge_requests/6...
User interface changes
None.
Issue fork experience_builder-3499703
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3499703-xb-routes-consistent
changes, plain diff MR !626 - 3499703-make-all-xb changes, plain diff MR !616
Comments
Comment #3
wim leers@tedbow also raised this earlier today :)
Comment #4
wim leersComment #6
nexusnovaz commentedAre we going to sort .routing by the route name, or the path?
Comment #7
wim leers#6: you can choose :)
FYI: one rename for consistency is already happening in #3484678: Simplify ComponentSourceInterface::getClientSideInfo(), introduce ClientSideRepresentation value object, and leverage it 🥳
Comment #8
anjali rathodComment #10
wim leersThanks for pushing this forward! 😊
Comment #15
anjali rathodComment #16
wim leersComment #17
wim leers#3499550: Support server-side massaging and validating of ComponentInputsForm values conflicted heavily with this. Rather than continuing to postpone this, I bit the bullet and redid parts of what @anjali rathod did.
Now doing a proper review!
Comment #18
wim leersConflicted with #3505774: Merge ApiPendingChangesController and ApiPublishAllController, clarify connection, but thanks to the unit test added here, fixing that was a breeze 😄
Comment #19
wim leersComment #21
wim leersComment #22
nagwani commentedComment #23
tedbowIt would good to get #3471064: OpenApi validation is not enforced because openapi.yml uses `patternProperties` which is not supported by our dependencies fixed next. We still have 3 large parts of openapi.yml spec that is getting ignored, and we will likely add more until we get this fixed(the problem got worse last month)
Comment #24
nagwani commented