Problem/Motivation

Some of our tests declare(strict_types=1);, and some don't.

Drupal Core already requires that All tests must declare the use of strict types: we should probably do that too.

Proposed resolution

Add declare(strict_types=1); to existing tests that don't have them. Fix any issues that show up.

Remaining tasks

  1. Write a patch
  2. Review and feedback - skipped as the code was contributed by a maintainer
  3. RTBC and feedback - skipped as the code was contributed by a maintainer
  4. Commit
  5. Release - in 8.0.0-alpha3

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork elasticsearch_connector-3498806

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mparker17 created an issue. See original summary.

mparker17 opened merge request !77

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes
Status: Active » Reviewed & tested by the community

Looking good to me.

  • mparker17 committed 8060ce48 on 8.0.x 
    Issue #3498806 by mparker17: Make all tests declare strict_types
mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Merged!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

Note this was released in elasticsearch_connector-8.0.0-alpha3.