Problem/Motivation

Steps to reproduce

Visit /admin/structure/types/manage/page/fields/add-field.
No proper icon for geolocation

Proposed resolution

Create icons for geofield type.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork geofield-3498685

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

anjaliprasannan created an issue. See original summary.

hetal.solanki’s picture

Assigned: Unassigned » hetal.solanki
hetal.solanki’s picture

Assigned: hetal.solanki » Unassigned
anjaliprasannan’s picture

Assigned: Unassigned » anjaliprasannan

anjaliprasannan’s picture

Status: Active » Needs review
StatusFileSize
new9.53 KB

I have used the geofield-icon from https://uxwing.com/country-icon/

dunx’s picture

I raised this issue against Drupal CMS as Geofield is one of only two field types that does not have its own icon within the new field UI. As this impacts the initial Drupal CMS user experience it would be great to have this fixed before the launch of Drupal CMS is 5 days :)

No icons

I will try and test this patch today.

itamair made their first commit to this issue’s fork.

itamair’s picture

Status: Needs review » Fixed
StatusFileSize
new8.48 KB

Ok thanks ... I just provided a new commit with the attached more appropriate Geofield Icon, better matching its Project Browser correspondent.

Merging MR !39 and deploying a new Geofield 8.x-1.63 release with this.

itamair’s picture

itamair’s picture

Status: Fixed » Needs work
itamair’s picture

Status: Needs work » Fixed

itamair’s picture

Assigned: anjaliprasannan » itamair
dunx’s picture

StatusFileSize
new102.6 KB

I just tested this.

  1. Fresh install of current D11.
  2. Applied that patch via https://git.drupalcode.org/issue/geofield-3498685.git
  3. Clock the "+ Create new field" on any content type.

The new icons appears as it should (in orange). [I've just tested the Address icon patch too (in yellow).]

Nice icons Sir!

Both of these contrib modules are part of Drupal CMS, which I why I'm keen to get both icons in place before the launch next week :). Thanks.

itamair’s picture

Hey guys here ... I have received some direct email claiming for credits on this,
but at the moment the Drupal Crediting system is a bit weird and not efficient.
I mentioned all of you in this merge commit: https://git.drupalcode.org/project/geofield/-/commit/cbfe9979bbe62379a7a...

BUT it seems Credits are only given the first time the issue is marked as Fixed, and the contributors names are checked ...
and if they don't, may be the credits are not really assigned in this weird system.

Sorry. May be I missed that ... then I retried doing that (set bak to Needs Work and then again into Fixed, having the contributors checked) but may be second time we do it doesn't apply anymore.

I DON'T KNOW what is not working in the Drupal.org Crediting system ... or why it is so unreliable.
Sorry if someone wasn't credited for all this.
But I cannot do more than this ... (and I have a lot of other stuff to stay after, and not really for free).

ressa’s picture

Hey @itamair, it worked well, and everyone was given credit, as far as I can tell. From down below:

Credit given to itamair, anjaliprasannan at QED42, dunx at Zoocha, hetal.solanki at cmsMinds

For example under @dunx profile, you can see this

Geofield issues credited to dunx

◀︎ Back to dunx’s profile
Create unique Geofield field type icon for better UX updated 48 min 23 sec ago

https://www.drupal.org/u/dunx/issue-credits/1087170

You can always check the credit process on https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett...

Quote:

Giving credit: Check and uncheck the names of users listed in the table, depending on whether they contributed to moving the issue towards resolution. The credits will appear on the user and organization profiles when the issue status is changed to Fixed, or when it automatically changes to Closed (fixed)

So, credit added after setting to Fixed ("forgotten credits") -- for example by checking all four checkboxes and simply updating the issue, those credits would have been added when the issue changed to "Closed (Fixed)". OR -- as you did, changed status, credited everyone, and then set back to "Fixed". Then the credit was granted immediately.

It's very sad that automatic crediting to issue contributors was disabled due to abuse ... so we need to navigate around it. Also, user names mentioned in Git commit issues are only for the Gitlab logs .. nothing else.

Gitlab commit message generator: The commit message is not used for credit attribution, it's all done via the above table. Use the checkboxes and Commit message field to generate a suggested commit message for the issue.

itamair’s picture

Thanks @ressa ... all good here.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.