Closed (fixed)
Project:
Geofield
Version:
8.x-1.62
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
10 Jan 2025 at 06:59 UTC
Updated:
25 Jan 2025 at 16:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
hetal.solankiComment #3
hetal.solankiComment #4
anjaliprasannan commentedComment #6
anjaliprasannan commentedI have used the geofield-icon from https://uxwing.com/country-icon/
Comment #7
dunx commentedI raised this issue against Drupal CMS as Geofield is one of only two field types that does not have its own icon within the new field UI. As this impacts the initial Drupal CMS user experience it would be great to have this fixed before the launch of Drupal CMS is 5 days :)
I will try and test this patch today.
Comment #9
itamair commentedOk thanks ... I just provided a new commit with the attached more appropriate Geofield Icon, better matching its Project Browser correspondent.
Merging MR !39 and deploying a new Geofield 8.x-1.63 release with this.
Comment #10
itamair commentedComment #11
itamair commentedComment #12
itamair commentedComment #14
itamair commentedComment #15
dunx commentedI just tested this.
The new icons appears as it should (in orange). [I've just tested the Address icon patch too (in yellow).]
Both of these contrib modules are part of Drupal CMS, which I why I'm keen to get both icons in place before the launch next week :). Thanks.
Comment #16
itamair commentedHey guys here ... I have received some direct email claiming for credits on this,
but at the moment the Drupal Crediting system is a bit weird and not efficient.
I mentioned all of you in this merge commit: https://git.drupalcode.org/project/geofield/-/commit/cbfe9979bbe62379a7a...
BUT it seems Credits are only given the first time the issue is marked as Fixed, and the contributors names are checked ...
and if they don't, may be the credits are not really assigned in this weird system.
Sorry. May be I missed that ... then I retried doing that (set bak to Needs Work and then again into Fixed, having the contributors checked) but may be second time we do it doesn't apply anymore.
I DON'T KNOW what is not working in the Drupal.org Crediting system ... or why it is so unreliable.
Sorry if someone wasn't credited for all this.
But I cannot do more than this ... (and I have a lot of other stuff to stay after, and not really for free).
Comment #17
ressaHey @itamair, it worked well, and everyone was given credit, as far as I can tell. From down below:
For example under @dunx profile, you can see this
https://www.drupal.org/u/dunx/issue-credits/1087170
You can always check the credit process on https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett...
Quote:
So, credit added after setting to Fixed ("forgotten credits") -- for example by checking all four checkboxes and simply updating the issue, those credits would have been added when the issue changed to "Closed (Fixed)". OR -- as you did, changed status, credited everyone, and then set back to "Fixed". Then the credit was granted immediately.
It's very sad that automatic crediting to issue contributors was disabled due to abuse ... so we need to navigate around it. Also, user names mentioned in Git commit issues are only for the Gitlab logs .. nothing else.
Comment #18
itamair commentedThanks @ressa ... all good here.