Problem/Motivation

The respect filter options do not appear anymore since newer versions of config_ignore do not rely on Config Filter as a requirement.

Steps to reproduce

Proposed resolution

Change 'config_filter' references to 'config_ignore'. This should work for older existing sites and newer ones where config_filter won't be present.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork config_patch-3497034

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kevinquillen created an issue. See original summary.

anish.ir’s picture

anish.ir commented
Assigned: Unassigned » anish.ir

Working on it.

anish.ir opened merge request !7

anish.ir’s picture

anish.ir commented
Assigned: anish.ir » Unassigned
Status: Active » Needs review

Hey,

I have changed the 'config_filter' references to 'config_ignore'. I think this will work for both - older sites containing config_filter and the new ones where config_filter is not present.

Please have a look.
Thank you !

shivam_tiwari’s picture

shivam_tiwari commented
Status: Needs review » Reviewed & tested by the community

I checked MR 7, it looks fine to me. Moving it to RTBC.

ahebrank made their first commit to this issue’s fork.

  • ahebrank committed f8493dc0 on 3.0.x authored by anish.ir 
    Issue #3497034 by anish.ir: Config Filter is no longer required by...
ahebrank’s picture

ahebrank commented
Status: Reviewed & tested by the community » Fixed
hchonov’s picture

hchonov
Primary language Bulgarian
Location Burgas
commented

I started getting this error

Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "config_ignore.storage_factory". in Drupal\Component\DependencyInjection\Container->get() (line 159 of /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php).

with backtrace

#0 /var/www/html/web/core/lib/Drupal.php(197): Drupal\Component\DependencyInjection\Container->get('config_ignore.s...')
#1 /var/www/html/web/modules/contrib/config_patch/src/ConfigCompare.php(248): Drupal::service('config_ignore.s...')
#2 /var/www/html/web/modules/contrib/config_patch/src/Controller/ConfigPatchToolbar.php(66): Drupal\config_patch\ConfigCompare->getChangelist()
#3 [internal function]: Drupal\config_patch\Controller\ConfigPatchToolbar->toolbarAjax()
#4 /var/www/html/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array(Array, Array)

Where is that service that you are using with the recent changes from this issue config_ignore.storage_factory coming from?

hchonov’s picture

hchonov
Primary language Bulgarian
Location Burgas
commented
Status: Fixed » Needs work
ahebrank’s picture

ahebrank commented

Yeah, that's unfortunate, this should not have been RTBC. The service is part of config_filter, so I'll revert this change and then we can figure out how to move forward to best support config_ignore.

  • 873d5da0 committed on 3.0.x 
    Revert Issue #3497034: Changed config filter references.
ahebrank’s picture

ahebrank commented
Status: Needs work » Closed (outdated)

I've verified that `config_ignore` settings are respected by `config_patch` without the module doing anything, so closing as obsolete. Seeing as `config_filter` is marked deprecated, I've removed references to that module on 3.0.x (thought about an update hook to remove the `respect_filter` setting but don't think it matters that much).