Problem/Motivation

This change breaks BC on some custom providers like Brightcove.

Issue fork video_embed_field-3496062

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mably created an issue. See original summary.

mably’s picture

mably commented
Related issues: +#3496022: ArgumentCountError: Too few arguments to function
mably’s picture

mably commented
Status: Active » Closed (won't fix)

Actually, that's not that simple, not sure we should do that.

In fact the providers should not override the ProviderPluginBase constructor and rathe use the create method for that.

mably opened merge request !51

mably’s picture

mably commented
Status: Closed (won't fix) » Needs review

Finally did a partial rollback, just disabling the FileSystem usage if not provided in the constructor.

That will only disable the Thumbnail download feature.

mably’s picture

mably commented
Status: Needs review » Fixed

  • mably committed d11e8532 on 3.0.x 
    Issue #3496062 by mably: Rollback the ProviderPluginBase constructor...

mably opened merge request !52

  • mably committed aaf7f09f on 3.0.x 
    Issue #3496062 by mably: Fixup ProviderPluginBase constructor signature...

mably opened merge request !53

  • mably committed 28c14ea0 on 3.0.x 
    Issue #3496062 by mably: Fixup ProviderPluginBase constructor signature...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.