Problem/Motivation
Convert hooks to the new OOP system, so we can separate the logic.
See change record: https://www.drupal.org/node/3442349
Proposed resolution
Convert hooks to the new OOP system, so we can separate the logic.
Keep the hooks and provide the hook classes as services for BC with 10.4 and 11.0.
Remaining tasks
MR
User interface changes
None.
API changes
None.
Data model changes
None.
Issue fork dashboard-3495987
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
penyaskitoWith the current MR we require ^11.1.
Not sure if we want to keep the legacy hooks to maintain compatibility with ^10.4.
Comment #4
plopescI really like how the code looks in the MR, but I feel that bumping core requirements to ^11.1 might be controversial.
We could maybe explore the
#[LegacyHook]approach to increase the number of sites that could adopt Dashboard module in this initial phase and gain more traction across the community. Removing those extra BC bits should be easy once we definitely remove 10.x support at some point.If we decide to bump the requirements, we could get rid of the conditional logic to handle login in
DashboardRedirectAfterLoginTest::setup().Comment #5
penyaskitoComment #6
penyaskito@plopesc TBH I wasn't even sure if merging this before 2.0.0. I added the BC layer, so we might do that, but then I'd tag a rc ASAP.
Comment #7
plopescMade a quick review and added a few comments. Most of them are just cosmetics.
Thank you for this one!
Comment #8
penyaskitoI wouldn't consider the hook implementations API, so not that concerned about these if need to change anyway.
Comment #9
plopescSounds good. Marking as RTBC
Comment #11
penyaskitoThanks, merged!