Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
Currently looks like this:
How I would expect it to look:
Steps to reproduce
Use Gin, install core Navigation module, and size the viewport narrow enough for the sidebar to be hidden and the top bar to be displayed.
Proposed resolution
Looks like this is partly due to core using different selectors and also that they hard code background-color: white rather than one of the custom properties.
Remaining tasks
Fix styles.
User interface changes
No longer looks busted.
API changes
None.
Data model changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | After-mr.png | 132.53 KB | djsagar |
| #5 | Before-mr.png | 130.49 KB | djsagar |
| #2 | gin-3488177-core-navigation-dark-mode-top-bar-correct-colour.png | 194.18 KB | ambient.impact |
| #2 | gin-3488177-core-navigation-dark-mode-top-bar-incorrect-colour.png | 192 KB | ambient.impact |
Issue fork gin-3488177
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
ambient.impactComment #4
djsagar commentedMoving this to 'Needs Review' as the MR has already been created.
Reviewing this as well.
Comment #5
djsagar commentedReproduced the issue on local and applied MR #3.
Testing Steps:
1. Use Gin.
2. install core Navigation module.
3. size the viewport narrow enough for the sidebar to be hidden and the top bar to be displayed.
Result:-
After MR the issue resolved for the small screen.
Before MR
After MR
RTBC ++
Comment #7
saschaeggi@ambient.impact thanks! 👏